You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org> on 2006/08/19 15:47:13 UTC
[jira] Created: (ADFFACES-144) client side validation: make
converters and validators responsible for formatting detail string
client side validation: make converters and validators responsible for formatting detail string
-----------------------------------------------------------------------------------------------
Key: ADFFACES-144
URL: http://issues.apache.org/jira/browse/ADFFACES-144
Project: MyFaces ADF-Faces
Issue Type: Improvement
Reporter: Gabrielle Crawford
currently the client side validation framework takes an exception and pulls out the facesMessage, then pulls the detail out of that, and replaces {0} with the label and {1} with the value. This process should be done by the converter or validator itself and not the framework.
This change would make the behavior equivalent to the behavior on the server where converters and validators must return fully formatted strings. However there is one difference between the client and server which is that there is a component available on the server which is passed to the public methods getAsObject, getAsString, validate. In general converters and validators on the server use the component to retrieve the label. On the client there is no component available.
The proposal is
1] pass the component's label to the client converter's getAsObject and getAsString methods, and to the validator's validate method.
2] Make the client formatting method public so it's available for the converters and validators to use, currently it's a private method.
3] stop having the framework do the replacement
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-144) client side validation: make
converters and validators responsible for formatting detail string
Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-144?page=all ]
Gabrielle Crawford updated ADFFACES-144:
----------------------------------------
Attachment: patch144.patch
> client side validation: make converters and validators responsible for formatting detail string
> -----------------------------------------------------------------------------------------------
>
> Key: ADFFACES-144
> URL: http://issues.apache.org/jira/browse/ADFFACES-144
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Gabrielle Crawford
> Attachments: patch144.patch
>
>
> currently the client side validation framework takes an exception and pulls out the facesMessage, then pulls the detail out of that, and replaces {0} with the label and {1} with the value. This process should be done by the converter or validator itself and not the framework.
> This change would make the behavior equivalent to the behavior on the server where converters and validators must return fully formatted strings. However there is one difference between the client and server which is that there is a component available on the server which is passed to the public methods getAsObject, getAsString, validate. In general converters and validators on the server use the component to retrieve the label. On the client there is no component available.
> The proposal is
> 1] pass the component's label to the client converter's getAsObject and getAsString methods, and to the validator's validate method.
> 2] Make the client formatting method public so it's available for the converters and validators to use, currently it's a private method.
> 3] stop having the framework do the replacement
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-144) client side validation: make
converters and validators responsible for formatting detail string
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-144?page=all ]
Matthias Weßendorf updated ADFFACES-144:
----------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Assignee: Matthias Weßendorf
thanks for the patch, has been committed to the trunk
> client side validation: make converters and validators responsible for formatting detail string
> -----------------------------------------------------------------------------------------------
>
> Key: ADFFACES-144
> URL: http://issues.apache.org/jira/browse/ADFFACES-144
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Gabrielle Crawford
> Assigned To: Matthias Weßendorf
> Attachments: patch144.patch
>
>
> currently the client side validation framework takes an exception and pulls out the facesMessage, then pulls the detail out of that, and replaces {0} with the label and {1} with the value. This process should be done by the converter or validator itself and not the framework.
> This change would make the behavior equivalent to the behavior on the server where converters and validators must return fully formatted strings. However there is one difference between the client and server which is that there is a component available on the server which is passed to the public methods getAsObject, getAsString, validate. In general converters and validators on the server use the component to retrieve the label. On the client there is no component available.
> The proposal is
> 1] pass the component's label to the client converter's getAsObject and getAsString methods, and to the validator's validate method.
> 2] Make the client formatting method public so it's available for the converters and validators to use, currently it's a private method.
> 3] stop having the framework do the replacement
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-144) client side validation: make
converters and validators responsible for formatting detail string
Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-144?page=all ]
Gabrielle Crawford updated ADFFACES-144:
----------------------------------------
Status: Patch Available (was: Open)
> client side validation: make converters and validators responsible for formatting detail string
> -----------------------------------------------------------------------------------------------
>
> Key: ADFFACES-144
> URL: http://issues.apache.org/jira/browse/ADFFACES-144
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Gabrielle Crawford
> Attachments: patch144.patch
>
>
> currently the client side validation framework takes an exception and pulls out the facesMessage, then pulls the detail out of that, and replaces {0} with the label and {1} with the value. This process should be done by the converter or validator itself and not the framework.
> This change would make the behavior equivalent to the behavior on the server where converters and validators must return fully formatted strings. However there is one difference between the client and server which is that there is a component available on the server which is passed to the public methods getAsObject, getAsString, validate. In general converters and validators on the server use the component to retrieve the label. On the client there is no component available.
> The proposal is
> 1] pass the component's label to the client converter's getAsObject and getAsString methods, and to the validator's validate method.
> 2] Make the client formatting method public so it's available for the converters and validators to use, currently it's a private method.
> 3] stop having the framework do the replacement
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira