You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/25 02:54:28 UTC
[GitHub] [flink] Myasuka opened a new pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Myasuka opened a new pull request #14744:
URL: https://github.com/apache/flink/pull/14744
## What is the purpose of the change
Currently, RocksDB memory control end-to-end tests failed with very small probability due to the limitation of RocksDB itself. In general, we think RocksDB memory control should take effect in most cases and cannot ensure it behaves perfectly. Thus, if the chance of exceeding the limit is really low, we can retry up to 3 times.
## Brief change log
Run the tests with at most three times and failed the end-to-end test case if all failed.
## Verifying this change
This change added tests and can be verified as follows:
Run the tests with at most three times and failed the end-to-end test case if all failed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-777247888
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-773884428
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "773884428",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "777247888",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766507051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-777578058
Do you think this PR is still relevant after the RocksDB version upgrade and using strict mode?
I understand that even strict mode is not totally strict, but is the improvement enough to stabilize the tests without this change?
If the answer to the above question is "yes", then I would suggest to not merge this PR, because it may hide problems if there is a regression in the memory management code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-877058317
@StephanEwen @Myasuka Could we close the PR? I closed the JIRA ticket as it did not appear in a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "773884428",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "777247888",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766651035
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-773884428
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-777255056
@StephanEwen , yes I agree with your concern. Current memory control mechanism of RocksDB cannot handle any malloced memory not inserted into block cache or write buffer, those just uncompressed data block could have OOM risk.
Actually we are trying several optimizations to improve customer experience:
1. Partitioned index option https://github.com/apache/flink/pull/14341 to help avoid performance problem during memory control.
1. Try to bump RocksDB after 6.10+ to have more restrict block cache size limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-776701157
This looks like a fair way to stabilize the tests, but it ultimately hides a real problem: The fact that the RocksDB memory footprint is not controllable.
I am fine with merging this, but we need to keep working on the other issue, to make the experience in containerized environments more smooth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "773884428",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "777247888",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "773884428",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-767972038
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766507051
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0a3a317f89be84c50608d6bd9514dde8367e3d5d (Thu Sep 23 18:00:38 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17511).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-817769158
@StephanEwen , sorry for missing this reply during my spring festival holidays. Flink-1.13 did not bump the RocksDB version finally and it seems there is no test failure reported during this time.
Maybe we could mark FLINK-17511 to be resolved in Flink-1.14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766507051
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0a3a317f89be84c50608d6bd9514dde8367e3d5d (Mon Jan 25 02:56:36 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766651035
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "773884428",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-767982133
@StephanEwen could you please take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "766651035",
"triggerType" : "MANUAL"
}, {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "767972038",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766515087
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433",
"triggerID" : "0a3a317f89be84c50608d6bd9514dde8367e3d5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a3a317f89be84c50608d6bd9514dde8367e3d5d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org