[GitHub] [kafka] vcrfxia commented on a diff in pull request #13510: KAFKA-14834: [4/N] Drop out-of-order records from table-table join with versioned tables

["vcrfxia (via GitHub)" <gi...@apache.org>]

vcrfxia commented on code in PR #13510:
URL: https://github.com/apache/kafka/pull/13510#discussion_r1160346509


##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java:
##########
@@ -3254,10 +3254,10 @@ public void shouldSupportTableTableJoinWithKStreamToKTable() {
                 "    Processor: KSTREAM-TOTABLE-0000000004 (stores: [KSTREAM-TOTABLE-STATE-STORE-0000000005])\n" +
                 "      --> KTABLE-JOINOTHER-0000000008\n" +
                 "      <-- KSTREAM-SOURCE-0000000003\n" +
-                "    Processor: KTABLE-JOINOTHER-0000000008 (stores: [KSTREAM-TOTABLE-STATE-STORE-0000000002])\n" +
+                "    Processor: KTABLE-JOINOTHER-0000000008 (stores: [KSTREAM-TOTABLE-STATE-STORE-0000000005, KSTREAM-TOTABLE-STATE-STORE-0000000002])\n" +

Review Comment:
   Just checking: adding state stores to an existing processor topology is a backwards-compatible change, right? I can't think of why it wouldn't be, but if it's not then that would mean compatibility concerns for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org