You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/21 14:56:02 UTC

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #532: lvgl porting and lvgl demo decoupling

v01d commented on pull request #532:
URL: https://github.com/apache/incubator-nuttx-apps/pull/532#issuecomment-749014612


   I'm not entirely convinced of this change. I see some that some of this code is part of `lv_drivers` repo, although not sure if there are no NuttX specific changes there (that would be the reason to ship them ourselves). On the other hand, while I can see benefit of having some generic code to access framebuffer, each project may require different way to initialize and access framebuffer so this generic function would not be appropriate. 
   Moreover, it exposes global functions with no LVGL specific prefix so I don't think it is appropriate to use them outside of LVGL demo.
   
   Can you explain what is the expected benefit of this change? Do you intend to reuse this on your own application?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org