You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/02 01:08:42 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29563: [SPARK-32719][PYTHON] Add Flake8 check missing imports

HyukjinKwon commented on a change in pull request #29563:
URL: https://github.com/apache/spark/pull/29563#discussion_r481519751



##########
File path: python/pyspark/ml/classification.py
##########
@@ -16,19 +16,24 @@
 #
 
 import operator
+import sys
+import uuid

Review comment:
       Oh @Fokko sorry I misread. It was fine because we're using wildcard imports at `from pyspark.ml.util import *` and `util` imports `uuid`. So it didn't crash before ..  Let's just don't port this back alone :-)..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org