You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Bill Stoddard <wg...@us.ibm.com> on 1998/06/24 19:19:58 UTC
[PATCH] Re: Filenames containing whitespace characters
This patch should fix the reported problem...
Bill Stoddard
wgstodda@us.ibm.com
Re: [PATCH] Re: Filenames containing whitespace characters
Posted by Bill Stoddard <wg...@us.ibm.com>.
Bill Stoddard wrote:
> Ben Laurie wrote:
>
> > Bill Stoddard wrote:
> > >
> > > This patch should fix the reported problem...
> >
> > Does it the code already deal with the quoting required in the
> > arguments?
> >
> > Cheers,
> >
> > Ben.
>
> The code does not add any quotes to the argument list and I don't think it should, if I understand
> your question. This patch constructs a quoted string from r->filename and uses that string to build
> the CreateProcess command line. The only other exposure I see is if someone creates a shebang line
> with spaces, E.g., #!/Program Files/perl/perl.exe. That's going to fail. (#!"/Program
> Files/perl/perl.exe" should work though...)
>
> Am I missing something?
>
> Bill Stoddard
> wgstodda@us.ibm.com
If there are no complaints, could someone put this patch into cvs?
Thanks,
Bill Stoddard
wgstodda@us.ibm.com
Re: [PATCH] Re: Filenames containing whitespace characters
Posted by Bill Stoddard <wg...@us.ibm.com>.
Ben Laurie wrote:
> Bill Stoddard wrote:
> >
> > This patch should fix the reported problem...
>
> Does it the code already deal with the quoting required in the
> arguments?
>
> Cheers,
>
> Ben.
The code does not add any quotes to the argument list and I don't think it should, if I understand
your question. This patch constructs a quoted string from r->filename and uses that string to build
the CreateProcess command line. The only other exposure I see is if someone creates a shebang line
with spaces, E.g., #!/Program Files/perl/perl.exe. That's going to fail. (#!"/Program
Files/perl/perl.exe" should work though...)
Am I missing something?
Bill Stoddard
wgstodda@us.ibm.com
Re: [PATCH] Re: Filenames containing whitespace characters
Posted by Ben Laurie <be...@algroup.co.uk>.
Bill Stoddard wrote:
>
> This patch should fix the reported problem...
Does it the code already deal with the quoting required in the
arguments?
Cheers,
Ben.
--
Ben Laurie |Phone: +44 (181) 735 0686| Apache Group member
Freelance Consultant |Fax: +44 (181) 735 0689|http://www.apache.org/
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd, |Apache-SSL author http://www.apache-ssl.org/
London, England. |"Apache: TDG" http://www.ora.com/catalog/apache/
WE'RE RECRUITING! http://www.aldigital.co.uk/recruit/