You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/09 05:14:57 UTC
[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #402: Add VPC（Virtual Private Cloud）support for go sdk
wolfstudy commented on a change in pull request #402:
URL: https://github.com/apache/pulsar-client-go/pull/402#discussion_r572599417
##########
File path: pulsar/internal/lookup_service_test.go
##########
@@ -117,9 +117,10 @@ func TestLookupSuccess(t *testing.T) {
expectedRequests: []pb.CommandLookupTopic{
{
- RequestId: proto.Uint64(1),
- Topic: proto.String("my-topic"),
- Authoritative: proto.Bool(false),
+ RequestId: proto.Uint64(1),
+ Topic: proto.String("my-topic"),
+ Authoritative: proto.Bool(false),
+ AdvertisedListenerName: proto.String(""),
Review comment:
@xixiss Can you add new test case for this change? This test case is used to cover other scenarios, please do not verify our own logic in this test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org