You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:07:10 UTC
[GitHub] [tvm] guberti commented on pull request #13051: [microTVM] Improve code reuse in Corstone300 conv2d tests
guberti commented on PR #13051:
URL: https://github.com/apache/tvm/pull/13051#issuecomment-1275918393
When reorganizing the tests, I noticed there was duplicate code in tests besides the `conv2d` ones. Each file has its own calls to `relay.op.nn.[operator]`, which are constructed the same way and then passed to `compile_and_run`.
- Would it make sense to create an even-more-abstract class that handled graph creation and running for all the tests in this directory, not just the `conv2d` variants?
- I would prefer to test our schedules by comparing them to external operator implementations - say, the Tensorflow ones - rather than by comparing them to our `x86` schedules. It would be much simpler to do this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org