You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/18 08:51:22 UTC

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7751: ARROW-9461: [Rust] Fixed error in reading Date32 and Date64.

jorgecarleitao edited a comment on pull request #7751:
URL: https://github.com/apache/arrow/pull/7751#issuecomment-660449463


   @sunchao , I was able to partially test the date64: I tested the conversion from i64 to date64 on the converters. Does not cover 100%, since it does not cover the array_reader, but it helps. I also added a test for the value conversion of date32.
   
   I also found how to test this in the `array_reader`; it just takes time because data64 cannot be tested by the macro `test_primitive_array_reader_one_type´: it requires us to use `ComplexObjectArrayReader::<Int64Type, Date64Converter>` instead of `PrimitiveArrayReader::<$arrow_parquet_type>` (used in `test_primitive_array_reader_one_type`).
   
   I would note that we currently do not test any type conversion on `array_reader` apart from the String and structs: the tests use the `PrimitiveArrayReader`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org