[jira] [Resolved] (KAFKA-2744) WorkerSourceTask commits offsets too early when stopping

["Guozhang Wang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guozhang Wang resolved KAFKA-2744.
----------------------------------
    Resolution: Fixed

Issue resolved by pull request 423
[https://github.com/apache/kafka/pull/423]

> WorkerSourceTask commits offsets too early when stopping
> --------------------------------------------------------
>
>                 Key: KAFKA-2744
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2744
>             Project: Kafka
>          Issue Type: Bug
>          Components: copycat
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.9.0.0
>
>
> The call to commit offsets appears ok at first glance because we've invoked the SourceTask's stop method, but it runs before we've stopped the work thread which could still be invoking the SourceTask's poll() method and may have outstanding data. We need to wait until we're sure the work thread has completely finished so we're guaranteed to flush all the data generated by the SourceTask and commit the final offsets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)