You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/02 08:46:00 UTC
[GitHub] [shardingsphere] pparthenhs opened a new pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
pparthenhs opened a new pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754
Fixes #15733.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#discussion_r817478531
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/scaling/update/ResetScalingStatementAssert.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.test.sql.parser.parameterized.asserts.statement.distsql.ral.impl.scaling.update;
+
+import org.apache.commons.collections4.CollectionUtils;
+import org.apache.shardingsphere.scaling.distsql.statement.ResetScalingStatement;
+import org.apache.shardingsphere.test.sql.parser.parameterized.asserts.SQLCaseAssertContext;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.ResetScalingStatementTestCase;
+
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.*;
Review comment:
Please do not use * to import dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#issuecomment-1056634802
Hi @pparthenhs
You should run `./mvnw clean install` `and make sure the local compilation passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#discussion_r817478691
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/SQLParserTestCases.java
##########
@@ -197,11 +197,7 @@
import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.ShowTransactionRuleStatementTestCase;
import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.ShowVariableStatementTestCase;
import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.UnlabelInstanceStatementTestCase;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.ApplyScalingStatementTestCase;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.CheckScalingStatementTestCase;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.RestoreScalingSourceWritingStatementTestCase;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.ShowScalingCheckAlgorithmsStatementTestCase;
-import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.StopScalingSourceWritingStatementTestCase;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.ral.scaling.*;
Review comment:
Please do not use * to import dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#discussion_r817479695
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/SQLParserTestCases.java
##########
@@ -766,7 +762,10 @@
@XmlElement(name = "apply-scaling")
private final List<ApplyScalingStatementTestCase> applyScalingStatementTestCases = new LinkedList<>();
-
+
Review comment:
Keep the indent consistent with the previous line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#issuecomment-1056793994
@pparthenhs
Very concise and accurate PR, thanks for your work.
I'll merge it after the CI is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pparthenhs commented on pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
pparthenhs commented on pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#issuecomment-1056706254
Dear @RaigorJiang ,
Really appreciate your time and collaboration. I have worked on your comments and I execute again the build and test using `./mvnw clean install` as you mentioned. And the build was a success.

I will remain at your disposal for anything needed.
Best Regards,
Panagiotis Parthenis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pparthenhs commented on pull request #15754: Add SQL parser test case for ResetScalingStatement (#15733)
Posted by GitBox <gi...@apache.org>.
pparthenhs commented on pull request #15754:
URL: https://github.com/apache/shardingsphere/pull/15754#issuecomment-1056812488
> @pparthenhs Very concise and accurate PR, thanks for your work. I'll merge it after the CI is successful.
I am happy to contribute !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org