You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/03 14:18:04 UTC

[jira] [Commented] (ARIA-148) Add CLI display commands

    [ https://issues.apache.org/jira/browse/ARIA-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994950#comment-15994950 ] 

ASF GitHub Bot commented on ARIA-148:
-------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/107#discussion_r114555739
  
    --- Diff: aria/cli/commands/service_templates.py ---
    @@ -181,21 +184,49 @@ def validate(service_template, service_template_filename,
         logger.info('Service template validated successfully')
     
     
    +@service_templates.command(name='display',
    +                           short_help='Display service template information')
    +@aria.argument('service-template-name')
    +@aria.options.verbose()
    +@aria.options.display_json
    +@aria.options.display_yaml
    +@aria.options.display_types
    +@aria.pass_model_storage
    +@aria.pass_logger
    +def display(service_template_name, model_storage, json, yaml, types, logger):
    --- End diff --
    
    Having both `display` and `show` is confusing :/
    I agree however that it doesn't make sense to make this command into a mere flag of `show` as they're very different.
    I'm generally ok with this as is, but Maxim wanted me to suggest `aria parse service/service-template` as an option as well. I'll leave it for your consideration :)


> Add CLI display commands
> ------------------------
>
>                 Key: ARIA-148
>                 URL: https://issues.apache.org/jira/browse/ARIA-148
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>
> {{aria service-templates display}}
> {{aria services display}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)