You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/08/15 06:50:15 UTC
[GitHub] incubator-gearpump pull request #74: [GEARPUMP-188] use java.time.Instant fo...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/74
[GEARPUMP-188] use java.time.Instant for Task start time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump replace_timestamp_with_instant
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 36593c49f53e50ff918561e0aa8dfc4aebe598d9
Author: manuzhang <ow...@gmail.com>
Date: 2016-05-31T05:10:24Z
[GEARPUMP-188] use java.time.Instant for Task start time
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #74: [GEARPUMP-188] use java.time.Instant fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #74: [GEARPUMP-188] use java.time.Instant for Task ...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
So we are not considering backward compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #74: [GEARPUMP-188] use java.time.Instant for Task ...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #74: [GEARPUMP-188] use java.time.Instant for Task ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/74?src=pr) is 70.69% (diff: 68.75%)
> Merging [#74](https://codecov.io/gh/apache/incubator-gearpump/pull/74?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will decrease coverage by **0.65%**
```diff
@@ master #74 diff @@
==========================================
Files 177 177
Lines 5931 5928 -3
Methods 5611 5609 -2
Messages 0 0
Branches 320 319 -1
==========================================
- Hits 4232 4191 -41
- Misses 1699 1737 +38
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [6d919ec...e55595f](https://codecov.io/gh/apache/incubator-gearpump/compare/6d919ec977e772d9d51fe2f35741f67d00af5c98...e55595f79a05d9540e65af42d6240293d81d5549?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #74: [GEARPUMP-188] use java.time.Instant for Task ...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
No. I'd rather we break things now than later or leave users confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---