You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/10 09:33:51 UTC

[GitHub] [camel-k] nicolaferraro commented on issue #1127: Don't write to platform spec to allow upgrades

nicolaferraro commented on issue #1127: Don't write to platform spec to allow upgrades
URL: https://github.com/apache/camel-k/pull/1127#issuecomment-563947237
 
 
   Yeah, I've thought to the last-applied-config as well, but semantically in Kube it serves to a different purpose. Having it as an annotation also make it difficult to understand the content when you inspect it. 
   
   It's also difficult, in case one changes with `k edit integrationplatform` some fields in the spec, when you get to reconcile it, to tell if a value in spec was set by the user or by our initialization code.
   
   I think we've done a similar thing to this PR also in Integration (e.g. you see many fields, like dependencies in both `status` and `spec`). Instead of having a `fullConfig` field, which seems odd, I was thinking to move the fields one level up. So that we have e.g. spec->build->baseImage and status->build->baseImage which seems close to what we've already done in integration and feels more natural.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services