[jira] [Commented] (SCB-684) Following swagger conventions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520058#comment-16520058 ] 

ASF GitHub Bot commented on SCB-684:
------------------------------------

liubao68 opened a new pull request #773: [SCB-684]Following swagger conventions. Adding and change some test cases.
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/773
 
 
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Following swagger conventions
> -----------------------------
>
>                 Key: SCB-684
>                 URL: https://issues.apache.org/jira/browse/SCB-684
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>            Reporter: liubao
>            Assignee: liubao
>            Priority: Major
>
> Check with swagger validator, some warnings and errors are given:
>  
>  
> Errors Hide Semantic error at paths./add.post Operations with Parameters of "in: formData" must include "application/x-www-form-urlencoded" or "multipart/form-data" in their "consumes" property Jump to line 13 Semantic error at paths./add.post Operations with Parameters of "in: formData" must include "application/x-www-form-urlencoded" or "multipart/form-data" in their "consumes" property Jump to line 13 Schema error at paths['/reduce'].get.parameters[0] should NOT have additional properties additionalProperty: type, format, name, in, required Jump to line 36 Schema error at paths['/reduce'].get.parameters[0].required should be equal to one of the allowed values allowedValues: true Jump to line 36 Schema error at paths['/reduce'].get.paramete



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)