You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/06/17 09:14:07 UTC
[jira] Created: (HBASE-1531) Change new Get to use new filter API
Change new Get to use new filter API
------------------------------------
Key: HBASE-1531
URL: https://issues.apache.org/jira/browse/HBASE-1531
Project: Hadoop HBase
Issue Type: Bug
Reporter: stack
Fix For: 0.20.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1531) Change new Get to use new filter API
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1531.
--------------------------
Resolution: Fixed
Thanks for the review Jon.
> Change new Get to use new filter API
> ------------------------------------
>
> Key: HBASE-1531
> URL: https://issues.apache.org/jira/browse/HBASE-1531
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.0
>
> Attachments: 1531-v2.patch, HBASE-1531-v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1531) Change new Get to use new filter API
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722027#action_12722027 ]
Jonathan Gray commented on HBASE-1531:
--------------------------------------
Patch reviewed, looks good. Tests pass. +1 on commit
And yes, considered & clean >> quick & dirty ;)
> Change new Get to use new filter API
> ------------------------------------
>
> Key: HBASE-1531
> URL: https://issues.apache.org/jira/browse/HBASE-1531
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.0
>
> Attachments: 1531-v2.patch, HBASE-1531-v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1531) Change new Get to use new filter API
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1531:
-------------------------
Attachment: 1531-v2.patch
Considered, clean patch that adds Test of Get+Filter (smile).
Here's commit message:
{code}
M src/test/org/apache/hadoop/hbase/regionserver/TestMemcache.java
M src/test/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java
M src/java/org/apache/hadoop/hbase/regionserver/Store.java
QueryMatcher constructor API changed.
M src/test/org/apache/hadoop/hbase/regionserver/TestHRegion.java
Added testing of a Get with a Filter on it.
M src/test/org/apache/hadoop/hbase/filter/TestRowPrefixFilter.java
Added test of prefix row filter wrapped with a RowWhileMatchFilter.
M src/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
Parent class now has a filter data member.
M src/java/org/apache/hadoop/hbase/regionserver/QueryMatcher.java
Implement filters on Get.
Changed constructor so we get the row from the passed Get object.
M src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
M src/java/org/apache/hadoop/hbase/filter/RowInclusiveStopFilter.java
M src/java/org/apache/hadoop/hbase/filter/Filter.java
M src/java/org/apache/hadoop/hbase/filter/RowPrefixFilter.java
M src/java/org/apache/hadoop/hbase/client/Put.java
Formatting.
M src/java/org/apache/hadoop/hbase/filter/ColumnCountFilter.java
A filter to test Get+Filter. Not much good for anything else.
M src/java/org/apache/hadoop/hbase/filter/package-info.java
Fixed doc.
M src/java/org/apache/hadoop/hbase/client/Get.java
Added getFilter accessor.
Changed Get to use new Filter type.
{code}
> Change new Get to use new filter API
> ------------------------------------
>
> Key: HBASE-1531
> URL: https://issues.apache.org/jira/browse/HBASE-1531
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.0
>
> Attachments: 1531-v2.patch, HBASE-1531-v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1531) Change new Get to use new filter API
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1531:
---------------------------------
Attachment: HBASE-1531-v1.patch
quick and dirty patch. removes old filters from Get (there were no filters on gets in 0.19), adds new filters to Get, and adds a KV check at the end of QueryMatcher.
> Change new Get to use new filter API
> ------------------------------------
>
> Key: HBASE-1531
> URL: https://issues.apache.org/jira/browse/HBASE-1531
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.0
>
> Attachments: HBASE-1531-v1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.