You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/10 10:07:15 UTC

[GitHub] [camel-quarkus] ppalaga opened a new issue #2225: Figure out how to maintain versions of test containers

ppalaga opened a new issue #2225:
URL: https://github.com/apache/camel-quarkus/issues/2225


   Our `ContainerResourceLifecycleManager` implementations often reference container versions. We have no process/tool in place that would ensure that the versions stay up to date, esp. that the version of the given container is close enough to the version of the respective library. 
   
   One possible solution that comes to my mind is to maintain the versions in the top pom.xml either using the same property as the respective library or using a separate property, but placing it along with the lib version prop, so that any discrepancy gets noticed when the lib is upgraded.
   
   Any other ideas?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #2225: Figure out how to maintain versions of test containers

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #2225:
URL: https://github.com/apache/camel-quarkus/issues/2225#issuecomment-776627125


   You mean we should start using Camel test-infra instead of our custom `ContainerResourceLifecycleManager`s? Can test-infra set the environment for the test that runs in a separate JVM?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] lburgazzoli commented on issue #2225: Figure out how to maintain versions of test containers

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #2225:
URL: https://github.com/apache/camel-quarkus/issues/2225#issuecomment-776630783


   We should at least investigate if we can use test-infra since it is used by camel and camel-kafka-connector.
   
   AFAIK each test-infra set some system properties so we probably need to wrap them in with a ResourceLifecycleManager but I guess it is doable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] lburgazzoli commented on issue #2225: Figure out how to maintain versions of test containers

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #2225:
URL: https://github.com/apache/camel-quarkus/issues/2225#issuecomment-776600858


   FWIW, there is a test-infra in Camel we could try to leverage so at least version can be aligned at Camel, of course we sometime need to override versions and in such case we can use the mechanic you described


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on issue #2225: Figure out how to maintain versions of test containers

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #2225:
URL: https://github.com/apache/camel-quarkus/issues/2225#issuecomment-776673287


   Slightly related, we may want to think about which base images we use, because it seems we're starting to run low on disk space in CI. Something I noticed in the Camel 3.8 upgrade PR:
   
   ```
   Caused by: java.lang.RuntimeException: Unable to start Quarkus test resource org.apache.camel.quarkus.component.vertx.kafka.it.VertxKafkaTestResource@64e05a38
   	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:57)
   	... 44 more
   Caused by: java.lang.RuntimeException: java.lang.IllegalStateException: Check failed: Docker environment should have more than 2GB free disk space
   	at org.apache.camel.quarkus.component.vertx.kafka.it.VertxKafkaTestResource.start(VertxKafkaTestResource.java:45)
   	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:52)
   	... 44 more
   Caused by: java.lang.IllegalStateException: Check failed: Docker environment should have more than 2GB free disk space
   	at org.testcontainers.DockerClientFactory.check(DockerClientFactory.java:298)
   ```
   
   IIRC we can disable those checks if we really need to. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org