[GitHub] [lucene] dweiss commented on a change in pull request #393: LUCENE-10185: pass --release 11 to ECJ linter, fix JDK 17 build

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #393:
URL: https://github.com/apache/lucene/pull/393#discussion_r731285380



##########
File path: lucene/core/src/java/org/apache/lucene/util/AttributeFactory.java
##########
@@ -148,7 +148,10 @@ public int hashCode() {
       AttributeFactory delegate, Class<A> clazz) {
     final MethodHandle constr = findAttributeImplCtor(clazz);
     return new StaticImplementationAttributeFactory<A>(delegate, clazz) {
+      // UweSays: It's ok. I know why it happens, but it's a bug. The type safety is checked by the

Review comment:
       Indeed. But I can't make javac complain about it if I try to do it in stand-alone mode (with linting). It does show up in intellij though, even if it claims it's using javac... go figure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org