[GitHub] [incubator-druid] gianm commented on issue #8091: groupBy with subtotalsSpec doesn't fully group each set

[GitBox <gi...@apache.org>]

gianm commented on issue #8091: groupBy with subtotalsSpec doesn't fully group each set
URL: https://github.com/apache/incubator-druid/issues/8091#issuecomment-512624659
 
 
   > I think current code "works" as long as first dimension from top level is included in the subtotal spec . That could be treated as a special optimized case and could use existing code path.
   
   I think it would need to be a stricter condition. The subtotal spec would need to be a prefix of the dimensions list for the current code to work. Even if it includes the first dimension, if it then skips the second and includes the third, the same issue can happen.
   
   > [d1, d3] ....can be computed from sorted results on [d1,d2,d3,d4]
   > [d2, d3] ...can be computed from sorted results on [d2,d3,d4]
   > [d2, d4] ...can be computed from sorted results on [d2,d3,d4]
   
   The middle one is true, but the first and last aren't, since the skipping of dimensions means that any later dimensions might not be seen in order.
   
   > are you working on it or would you like me to send the PR to fix it ?
   
   I am not working on a fix, I just noticed the problem while working on a different patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org