You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vgmartinez <gi...@git.apache.org> on 2015/08/18 11:41:21 UTC
[GitHub] incubator-zeppelin pull request: add notification
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/224
add notification
add notification when saved paragraph
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 69bb963db1dfe1a3573349ad48d9e421ccf445dd
Author: Victor <vi...@gmail.com>
Date: 2015-08-18T09:37:29Z
add notification when saved paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add notification
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/224#issuecomment-132465417
hi @Leemoonsoo ,
makes sense, sorry they had not seen the display ... but I think we can use notifications in other actions such as deleting a paragraph ... as they see?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add notification
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/224#issuecomment-132378751
Thanks @vgmartinez for adding notification.
I think notification is going to be useful, in general. This branch notify 'Saved' message when code is autosaved by timer. I'm not sure about this particular notification, because
- Saving code is already have visual indicator. (color of left vertical bar)
- Other actions (Run, etc) also saves code. Notifying only when autosaved by timer may confuse user, that other actions does not save the code.
By the way, here's a screenshot, how it looks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add notification
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/224#issuecomment-132678565
Yes, notification would be useful for many cases. (connection error, etc)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add notification
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add notification
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/224#issuecomment-132450208
This is good. We can used notification for showing data validation messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---