Re: [jclouds/jclouds-labs] JCLOUDS-1304: add azure customdata, JCLOUDS-1305: add support for ssh keys in keyvault (#398)

[Ignasi Barrera <no...@github.com>]

nacx requested changes on this pull request.

Thanks, @VRanga000 and apologies for the late review!
I see the key vault option being added but it is not used anywhere. Are there plans to add that later? In that case, Does it make more sense to add that option then too?

> @@ -41,7 +41,17 @@
    private List<IpOptions> ipOptions = ImmutableList.of();
    private WindowsConfiguration windowsConfiguration;
    private List<Secrets> secrets = ImmutableList.of();
-   
+   private String customData;

In mots providers, we declare this as a `byte[]`, so we don't have to deal with charset issues, etc. We just get the bytes to be base64-encoded. Mind changing the type and method signatures to accept a byte array?

> @@ -114,6 +124,14 @@ public AzureTemplateOptions windowsConfiguration(WindowsConfiguration windowsCon
     }
 
    /**
+    * Sets the KeyVault id and secret separated with ":"
+    */
+   public  AzureTemplateOptions keyVaultIdAndSecret(String keyVaultIdAndSecret) {
+      this.keyVaultIdAndSecret = keyVaultIdAndSecret;

Validate that the parameter has the right format.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/398#pullrequestreview-45088864