You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/02/21 02:44:20 UTC

Re: Review Request 74312: RANGER-4102: fixed incorrect TestPolicyACLs unit tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74312/
-----------------------------------------------------------

(Updated Feb. 21, 2023, 2:44 a.m.)


Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Vishal Gupta.


Summary (updated)
-----------------

RANGER-4102: fixed incorrect TestPolicyACLs unit tests


Bugs: RANGER-4102
    https://issues.apache.org/jira/browse/RANGER-4102


Repository: ranger


Description (updated)
-------

- TestPolicyACLs tests didn't validate the number of ACLs
- after adding these validations, 3 tests reported failure
- 2 of these failures were due to incorrect tests which expected deny when only allowExcpetion was present
- 1 of these failures was due to missing resourceMatchScope in the request
- after updating these tests, unit tests pass successfully.


Diffs (updated)
-----

  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java a7f48bb33 
  agents-common/src/test/resources/policyengine/test_aclprovider_default.json 8b799acff 


Diff: https://reviews.apache.org/r/74312/diff/2/

Changes: https://reviews.apache.org/r/74312/diff/1-2/


Testing
-------

- verified that all unit tests pass successfully


Thanks,

Madhan Neethiraj