[GitHub] [maven] michael-o commented on a change in pull request #512: [MNG-7010] Omit "NB: JAVA_HOME should point to a JDK not a JRE" excep…

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #512:
URL: https://github.com/apache/maven/pull/512#discussion_r675866515



##########
File path: apache-maven/src/assembly/shared/init
##########
@@ -50,14 +50,15 @@ if [ -z "$JAVACMD" ] ; then
 fi
 
 if [ ! -x "$JAVACMD" ] ; then
-  echo "The JAVA_HOME environment variable is not defined correctly" >&2
-  echo "This environment variable is needed to run this program" >&2
-  echo "NB: JAVA_HOME should point to a JDK not a JRE" >&2
+  echo "The JAVA_HOME environment variable is not defined correctly," >&2
+  echo "this environment variable is needed to run this program." >&2
   exit 1
 fi
 
 if [ -z "$JAVA_HOME" ] ; then
   echo "Warning: JAVA_HOME environment variable is not set." >&2
+elif [ ! -x "$JAVA_HOME/bin/javac" ] ; then

Review comment:
       Isn't it done with `if [ ! -x "$JAVACMD" ] ; then`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org