You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2024/04/15 20:44:06 UTC

[I] Different behavior of distinct count on null inputs [arrow-datafusion-comet]

viirya opened a new issue, #267:
URL: https://github.com/apache/arrow-datafusion-comet/issues/267

   ### Describe the bug
   
   A few Spark tests with distinct count failed while working on #250: https://github.com/apache/arrow-datafusion-comet/actions/runs/8681807652/job/23805034669?pr=250
   
   ```
   [info] TwoLevelAggregateHashMapSuite:
   [info] - multiple column distinct count *** FAILED *** (530 milliseconds)
   [info]   Results do not match for query:
   ...
   [info]   == Results ==
   [info]   !== Correct Answer - 1 ==   == Spark Answer - 1 ==
   [info]   !struct<>                   struct<count(key1, key2, key3):bigint>
   [info]   ![3]                        [4] (QueryTest.scala:243)
   ```
   
   Spark distinct count aggregation doesn't count null inputs. I.e.,
   
   ```scala
   override lazy val updateExpressions = {
     ..
     Seq(
       /* count = */ If(nullableChildren.map(IsNull).reduce(Or), count, count + 1L)
     )
   }
   ```
   
   But seems DataFusion `count` aggregation function behaves differently.
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Different behavior of distinct count on null inputs [arrow-datafusion-comet]

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #267:
URL: https://github.com/apache/arrow-datafusion-comet/issues/267#issuecomment-2057775102

   I'm working on this to find out the root cause.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Different behavior of distinct count on null inputs [arrow-datafusion-comet]

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed issue #267: Different behavior of distinct count on null inputs
URL: https://github.com/apache/arrow-datafusion-comet/issues/267


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org