[GitHub] [hive] pvary commented on a change in pull request #2266: HIVE-24663 : Batch process in ColStatsProcessor for partitions

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2266:
URL: https://github.com/apache/hive/pull/2266#discussion_r636827308



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
##########
@@ -213,11 +214,14 @@ private void getColumnDataColPathSpecified(Table table, Partition part, List<Fie
       }
     } else {
       List<String> partitions = new ArrayList<String>();
-      partitions.add(part.getName());
+      // The partition name is converted to lowercase before generating the stats. So we should use the same

Review comment:
       Isn't this an issue?
   
   I mean the `key=US` an `key=us` should be a different partition key, so modifying the values could cause issues later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org