You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Mmuzaf (via GitHub)" <gi...@apache.org> on 2023/07/27 12:33:58 UTC
[GitHub] [cassandra] Mmuzaf commented on a diff in pull request #2519: CASSANDRA-18697 Skip ColumnFamilyStore#topPartitions initialization when client or tool mode
Mmuzaf commented on code in PR #2519:
URL: https://github.com/apache/cassandra/pull/2519#discussion_r1276215105
##########
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##########
@@ -558,7 +558,7 @@ public ColumnFamilyStore(Keyspace keyspace,
repairManager = new CassandraTableRepairManager(this);
sstableImporter = new SSTableImporter(this);
- if (SchemaConstants.isSystemKeyspace(getKeyspaceName()))
+ if (DatabaseDescriptor.isClientOrToolInitialized() || SchemaConstants.isSystemKeyspace(getKeyspaceName()))
Review Comment:
Do we have a test to verify this fix locally? I mean not exactly the initialization itself, but at least a test where we can see the log message mentioned in the JIRA issue. I have briefly searched for such a test and failed to find any :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org