[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42454: [SPARK-44776][CONNECT] Add ProducedRowCount to SparkListenerConnectOperationFinished

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on code in PR #42454:
URL: https://github.com/apache/spark/pull/42454#discussion_r1294343162


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/SparkConnectPlanExecution.scala:
##########
@@ -163,7 +165,7 @@ private[execution] class SparkConnectPlanExecution(executeHolder: ExecuteHolder)
               // Collect errors and propagate them to the main thread.
               .andThen {
                 case Success(_) =>
-                  executePlan.eventsManager.postFinished()
+                  executePlan.eventsManager.postFinished(Some(totalNumRows))

Review Comment:
   > I believe we have to move postFinished after ThreadUtils.awayReady
   
   +1, becaues resultHandler only sends signal to the loop below that sends batch



##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala:
##########
@@ -402,6 +420,7 @@ case class SparkListenerConnectOperationFinished(
     jobTag: String,
     operationId: String,
     eventTime: Long,
+    producedRowCount: Option[Long] = None,

Review Comment:
   add param doc above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org