[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #117: Sorts bin packing by weights in descending order

[GitBox <gi...@apache.org>]

prodeezy commented on a change in pull request #117: Sorts bin packing by weights in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266422325
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
 ##########
 @@ -33,20 +33,22 @@
   public static class ListPacker<T> {
     private final long targetWeight;
     private final int lookback;
+    private final boolean expensiveTaskFirst;
 
-    public ListPacker(long targetWeight, int lookback) {
+    public ListPacker(long targetWeight, int lookback, boolean expensiveTaskFirst) {
       this.targetWeight = targetWeight;
       this.lookback = lookback;
+      this.expensiveTaskFirst = expensiveTaskFirst;
 
 Review comment:
   I agree with this being a boolean option on the BaseTableScan but would it be more elegant to use a Comparator here instead of boolean so that ListPacker can be used for other possible sorting criteria? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org