You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/24 19:18:23 UTC

[GitHub] [superset] graceguo-supercat opened a new issue #14791: [native filter] filter component can not force refresh options

graceguo-supercat opened a new issue #14791:
URL: https://github.com/apache/superset/issues/14791


   User can not force refresh data for filter component, it only re-run query and get cached results.
   
   #### Screenshots
   How about force run query in populate/refresh action:
   <img width="563" alt="Screen Shot 2021-05-24 at 12 16 45 PM" src="https://user-images.githubusercontent.com/27990562/119396612-edbc1580-bc89-11eb-8e20-0ac3472c67df.png">
   
   
   ### Environment
   
   latest master
   
   
   ### Additional context
   
   cc @junlincc @villebro 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #14791: [native filter] filter component can not force refresh options

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #14791:
URL: https://github.com/apache/superset/issues/14791#issuecomment-860711399


   > > think the best solution here is adding a 🔄 type of button next to the filter to make it possible to
   > 
   > Did you mean to create a button specifically for this page? How common is this requirement throughout the application?
   
   I think we could reuse this one from SQL Lab:
   ![image](https://user-images.githubusercontent.com/33317356/121905147-82b6a980-cd32-11eb-9298-20d7b54a0d56.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] michael-s-molina commented on issue #14791: [native filter] filter component can not force refresh options

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14791:
URL: https://github.com/apache/superset/issues/14791#issuecomment-860652318


   > think the best solution here is adding a 🔄 type of button next to the filter to make it possible to
   
   Did you mean to create a button specifically for this page? How common is this requirement throughout the application?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #14791: [native filter] filter component can not force refresh options

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #14791:
URL: https://github.com/apache/superset/issues/14791#issuecomment-860728371


   Ah, right. If we add it as a native feature, we need to make sure we make it possible to pad selects that don't have the refresh enabled to align them with others that have it, like here:
   
   ![image](https://user-images.githubusercontent.com/33317356/121907746-0376a500-cd35-11eb-891c-7c25e5a45e07.png)
   
   Also, if we do add it, we'll have to make sure the hook for it is easy and straight forward to implement and causes minimal code duplication (not saying it can't be done, just haven't thought it through yet).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] michael-s-molina commented on issue #14791: [native filter] filter component can not force refresh options

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14791:
URL: https://github.com/apache/superset/issues/14791#issuecomment-860723849


   > > > think the best solution here is adding a 🔄 type of button next to the filter to make it possible to
   > > 
   > > 
   > > Did you mean to create a button specifically for this page? How common is this requirement throughout the application?
   > 
   > I think we could reuse this one from SQL Lab:
   > ![image](https://user-images.githubusercontent.com/33317356/121905147-82b6a980-cd32-11eb-9298-20d7b54a0d56.png)
   
   My question is more about if this should be a native feature of our selects or something specific for this page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] michael-s-molina commented on issue #14791: [native filter] filter component can not force refresh options

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14791:
URL: https://github.com/apache/superset/issues/14791#issuecomment-860254222


   @graceguo-supercat @villebro @junlincc https://github.com/apache/superset/pull/14824 removed the Populate and Refresh buttons to facilitate the user experience when retrieving the values. If we want to support force refresh we have some options:
   - Leave as it is and use the search when looking for a specific value 
   - Disable cache for specific selects
   - Create a refresh button specifically for this page
   - Create some sort of refresh button as a native feature of our selects


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #14791: [native filter] filter component can not force refresh options

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #14791:
URL: https://github.com/apache/superset/issues/14791#issuecomment-860459003


   I think the best solution here is adding a 🔄  type of button next to the filter to make it possible to trigger a `force=true` query.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org