[GitHub] spark pull request #17906: [SPARK-20665][SQL]"Bround" and "Round" function r...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17906#discussion_r115930145
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala ---
    @@ -546,15 +546,14 @@ class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
         val bdResults: Seq[BigDecimal] = Seq(BigDecimal(3.0), BigDecimal(3.1), BigDecimal(3.14),
           BigDecimal(3.142), BigDecimal(3.1416), BigDecimal(3.14159),
           BigDecimal(3.141593), BigDecimal(3.1415927))
    -    // round_scale > current_scale would result in precision increase
    -    // and not allowed by o.a.s.s.types.Decimal.changePrecision, therefore null
    --- End diff --
    
    seems we are changing the behavior, can you check with other database and see if it's expected to return the original value for this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org