[L] Change in asterixdb[master]: [ASTERIXDB-3838][EXT]: Sync GCS FileIO, fix auth

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Hussain Towaileb <hu...@gmail.com>:

Attention is currently required from: Hussain Towaileb.

Hello Anon. E. Moose #1000171, Jenkins, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21747?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Contrib+1 by Anon. E. Moose #1000171, Integration-Tests+1 by Jenkins


Change subject: [ASTERIXDB-3838][EXT]: Sync GCS FileIO, fix auth
......................................................................

[ASTERIXDB-3838][EXT]: Sync GCS FileIO, fix auth

The forked org.apache.iceberg.gcp.gcs package was stale at 1.10.0 while
the tree builds against 1.11.0. Re-copied verbatim from the 1.11.0
sources jar. OAuth2RefreshCredentialsHandler is copied in as well, which
lets GCSFileIO keep upstream's credential refresh instead of dropping
it. Only PrefixedStorage and GCSInputFile still differ from upstream;
each says how in its javadoc.

Separately, an external collection's own AT <link> was inert on the GCS
path. PrefixedStorage built its Storage client from the whole property
map, in which filterCatalogProperties leaves the catalog's credentials
unprefixed, so every collection on a catalog authenticated as the
catalog. Measured over a private bucket: a valid link, a link holding
another project's credentials, and no link at all all read the same
table. It now filters to the collection's properties, as
EnsureCloseAWSClientFactory and setIcebergAdlsAuthParams already do for
S3 and ADLS. The catalog still authenticates with its own link, and the
anonymous type becomes reachable.

setIcebergAdlsAuthParams is refactored to read those properties once
instead of prefixing each lookup. No behaviour change.

Ext-ref: MB-73557, MB-73934
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: Ibb117975e57407b15735153a9f9f97afbe19e3d4
---
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/azure/datalake/DatalakeUtils.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/BaseGCSFile.java
A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSExceptionUtil.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSFileIO.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSInputFile.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSInputStream.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSLocation.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSOutputFile.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSOutputStream.java
A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/OAuth2RefreshCredentialsHandler.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/PrefixedStorage.java
11 files changed, 386 insertions(+), 76 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/21747/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21747?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibb117975e57407b15735153a9f9f97afbe19e3d4
Gerrit-Change-Number: 21747
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Attention: Hussain Towaileb <hu...@gmail.com>