You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/13 22:07:04 UTC
[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Jim Apple has uploaded a new patch set (#5).

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................

IMPALA-4110: Clean up issues found by Apache RAT.

The script and support files are in another patch:

https://gerrit.cloudera.org/#/c/4405/

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/comparison/conftest.py
M tests/test-hive-udfs/pom.xml
280 files changed, 1,292 insertions(+), 1,648,831 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>