You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/28 09:20:44 UTC

[GitHub] [inlong] woofyzhao opened a new pull request, #7087: [INLONG-7086][DataProxy] Add default ext tag report value

woofyzhao opened a new pull request, #7087:
URL: https://github.com/apache/inlong/pull/7087

   
   - Fixes #7086
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] woofyzhao commented on a diff in pull request #7087: [INLONG-7086][DataProxy] Add default ext tag report value

Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #7087:
URL: https://github.com/apache/inlong/pull/7087#discussion_r1058770229


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/heartbeat/HeartbeatManager.java:
##########
@@ -56,6 +56,7 @@ public class HeartbeatManager implements AbstractHeartbeatManager {
 
     public static final String DEFAULT_CLUSTER_TAG = "default_cluster";
     public static final String DEFAULT_CLUSTER_NAME = "default_dataproxy";
+    public static final String DEFAULT_CLUSTER_EXT_TAG = "default=true";

Review Comment:
   A predefined default value for dp's secondary cluster  tag which is also consistent with the value used at manager.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] healchow commented on a diff in pull request #7087: [INLONG-7086][DataProxy] Add default ext tag report value

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7087:
URL: https://github.com/apache/inlong/pull/7087#discussion_r1058734712


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/heartbeat/HeartbeatManager.java:
##########
@@ -56,6 +56,7 @@ public class HeartbeatManager implements AbstractHeartbeatManager {
 
     public static final String DEFAULT_CLUSTER_TAG = "default_cluster";
     public static final String DEFAULT_CLUSTER_NAME = "default_dataproxy";
+    public static final String DEFAULT_CLUSTER_EXT_TAG = "default=true";

Review Comment:
   Why `default=true`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] woofyzhao commented on a diff in pull request #7087: [INLONG-7086][DataProxy] Add default ext tag report value

Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #7087:
URL: https://github.com/apache/inlong/pull/7087#discussion_r1058770229


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/heartbeat/HeartbeatManager.java:
##########
@@ -56,6 +56,7 @@ public class HeartbeatManager implements AbstractHeartbeatManager {
 
     public static final String DEFAULT_CLUSTER_TAG = "default_cluster";
     public static final String DEFAULT_CLUSTER_NAME = "default_dataproxy";
+    public static final String DEFAULT_CLUSTER_EXT_TAG = "default=true";

Review Comment:
   k=v is the format for extTag
   this default value is also used at manager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] woofyzhao merged pull request #7087: [INLONG-7086][DataProxy] Add default ext tag report value

Posted by GitBox <gi...@apache.org>.
woofyzhao merged PR #7087:
URL: https://github.com/apache/inlong/pull/7087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org