You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/05/25 13:57:54 UTC
(commons-validator) branch master updated (90c4e608 -> c4fb1000)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
from 90c4e608 Merge pull request #227 from apache/dependabot/github_actions/codecov/codecov-action-4.4.1
new 3bb0aae6 Fix PMD UnnecessaryFullyQualifiedName
new 7f281d03 Fix PMD UnnecessaryFullyQualifiedName
new ed91688d Fix PMD UnnecessaryFullyQualifiedName
new 768dd789 Fix PMD UnnecessaryFullyQualifiedName
new c4fb1000 Bump org.apache.commons:commons-parent from 69 to 70
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 2 +-
src/changes/changes.xml | 3 ++-
src/conf/spotbugs-exclude-filter.xml | 10 ++++++++++
.../commons/validator/routines/checkdigit/CUSIPCheckDigit.java | 2 +-
.../commons/validator/routines/checkdigit/ISINCheckDigit.java | 2 +-
.../validator/routines/checkdigit/ModulusTenCheckDigit.java | 2 +-
6 files changed, 16 insertions(+), 5 deletions(-)
(commons-validator) 04/05: Fix PMD UnnecessaryFullyQualifiedName
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit 768dd7894c0d534faeed2c56164e21b80b83fae5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 25 09:55:55 2024 -0400
Fix PMD UnnecessaryFullyQualifiedName
---
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index f2b3595f..4e5e8bd0 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -74,6 +74,7 @@ The <action> type attribute can be add,update,fix,remove.
<!-- FIX -->
<action type="fix" issue="VALIDATOR-492" dev="ggregory" due-to="Tobias Wildgruber, Gary Gregory">ValidatorUtils.copyFastHashMap is broken.</action>
<action type="fix" dev="ggregory" due-to="Sebb">DomainValidator: Changes from Version 2024040200, Apr 2 07:07:02 2024 UTC.</action>
+ <action type="fix" dev="ggregory" due-to="Gary GRegory">Fix PMD UnnecessaryFullyQualifiedName.</action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Dependabot">Bump org.apache.commons:commons-parent from 65 to 69 #201.</action>
<action type="update" dev="ggregory" due-to="Dependabot">Bump commons-logging:commons-logging from 1.3.0 to 1.3.2 #199, #221.</action>
(commons-validator) 05/05: Bump org.apache.commons:commons-parent from 69 to 70
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit c4fb10007ba8ab5560270883467a8d75608e02da
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 25 09:57:11 2024 -0400
Bump org.apache.commons:commons-parent from 69 to 70
---
pom.xml | 2 +-
src/changes/changes.xml | 2 +-
src/conf/spotbugs-exclude-filter.xml | 10 ++++++++++
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 282e5e01..39abff16 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>69</version>
+ <version>70</version>
</parent>
<groupId>commons-validator</groupId>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4e5e8bd0..f8101897 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -76,7 +76,7 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Sebb">DomainValidator: Changes from Version 2024040200, Apr 2 07:07:02 2024 UTC.</action>
<action type="fix" dev="ggregory" due-to="Gary GRegory">Fix PMD UnnecessaryFullyQualifiedName.</action>
<!-- UPDATE -->
- <action type="update" dev="ggregory" due-to="Dependabot">Bump org.apache.commons:commons-parent from 65 to 69 #201.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot, Gary Gregory">Bump org.apache.commons:commons-parent from 65 to 70 #201.</action>
<action type="update" dev="ggregory" due-to="Dependabot">Bump commons-logging:commons-logging from 1.3.0 to 1.3.2 #199, #221.</action>
<action type="update" dev="ggregory" due-to="Dependabot">Bump org.apache.commons:commons-csv from 1.10.0 to 1.11.0 #214.</action>
</release>
diff --git a/src/conf/spotbugs-exclude-filter.xml b/src/conf/spotbugs-exclude-filter.xml
index ca6b09da..11915133 100644
--- a/src/conf/spotbugs-exclude-filter.xml
+++ b/src/conf/spotbugs-exclude-filter.xml
@@ -38,4 +38,14 @@
<Class name="org.apache.commons.validator.routines.CreditCardValidator$1" />
<Bug pattern="SE_BAD_FIELD" />
</Match>
+ <Match>
+ <!-- Doesn't make sense and compatibility. -->
+ <Class name="~.*" />
+ <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR" />
+ </Match>
+ <Match>
+ <!-- Doesn't make sense and compatibility. -->
+ <Class name="~.*" />
+ <Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE" />
+ </Match>
</FindBugsFilter>
(commons-validator) 02/05: Fix PMD UnnecessaryFullyQualifiedName
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit 7f281d03a856c5173b780cafddb08d9d75f14063
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 25 09:55:14 2024 -0400
Fix PMD UnnecessaryFullyQualifiedName
---
.../apache/commons/validator/routines/checkdigit/ISINCheckDigit.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigit.java b/src/main/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigit.java
index 77edac3f..1b0341df 100644
--- a/src/main/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigit.java
+++ b/src/main/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigit.java
@@ -103,6 +103,6 @@ public final class ISINCheckDigit extends ModulusCheckDigit {
protected int weightedValue(final int charValue, final int leftPos, final int rightPos) {
final int weight = POSITION_WEIGHT[rightPos % 2]; // CHECKSTYLE IGNORE MagicNumber
final int weightedValue = charValue * weight;
- return ModulusCheckDigit.sumDigits(weightedValue);
+ return sumDigits(weightedValue);
}
}
(commons-validator) 01/05: Fix PMD UnnecessaryFullyQualifiedName
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit 3bb0aae6ceb5c67834f95b6f3ea63e01bb9faad8
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 25 09:55:09 2024 -0400
Fix PMD UnnecessaryFullyQualifiedName
---
.../commons/validator/routines/checkdigit/ModulusTenCheckDigit.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCheckDigit.java b/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCheckDigit.java
index 3ca056cd..31e21d5c 100644
--- a/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCheckDigit.java
+++ b/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCheckDigit.java
@@ -244,7 +244,7 @@ public final class ModulusTenCheckDigit extends ModulusCheckDigit {
final int weight = postitionWeight[(pos - 1) % postitionWeight.length];
int weightedValue = charValue * weight;
if (sumWeightedDigits) {
- weightedValue = ModulusCheckDigit.sumDigits(weightedValue);
+ weightedValue = sumDigits(weightedValue);
}
return weightedValue;
}
(commons-validator) 03/05: Fix PMD UnnecessaryFullyQualifiedName
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit ed91688d921bdcfaad09c658fca952c9082dfc34
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 25 09:55:18 2024 -0400
Fix PMD UnnecessaryFullyQualifiedName
---
.../apache/commons/validator/routines/checkdigit/CUSIPCheckDigit.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigit.java b/src/main/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigit.java
index b263223e..fbf870dd 100644
--- a/src/main/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigit.java
+++ b/src/main/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigit.java
@@ -93,6 +93,6 @@ public final class CUSIPCheckDigit extends ModulusCheckDigit {
protected int weightedValue(final int charValue, final int leftPos, final int rightPos) {
final int weight = POSITION_WEIGHT[rightPos % 2];
final int weightedValue = charValue * weight;
- return ModulusCheckDigit.sumDigits(weightedValue);
+ return sumDigits(weightedValue);
}
}