You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/02/19 09:02:08 UTC
Re: Review Request 17342: Updated Log::Reader and Log::Writer to be
asynchronous.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17342/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 8:02 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Updates from review comments.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
Diff: https://reviews.apache.org/r/17342/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 17342: Updated Log::Reader and Log::Writer to be
asynchronous.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 3, 2014, 10:38 p.m., Ben Mahler wrote:
> > src/log/log.hpp, line 163
> > <https://reviews.apache.org/r/17342/diff/2/?file=497552#file497552line163>
> >
> > This comment needs updating to remove 'none'.
These got updated in subsequent reviews.
> On March 3, 2014, 10:38 p.m., Ben Mahler wrote:
> > src/log/log.hpp, line 172
> > <https://reviews.apache.org/r/17342/diff/2/?file=497552#file497552line172>
> >
> > This comment needs updating for 'none'.
These got updated in subsequent reviews.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17342/#review36047
-----------------------------------------------------------
On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17342/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17342/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17342: Updated Log::Reader and Log::Writer to be
asynchronous.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17342/#review36047
-----------------------------------------------------------
Ship it!
src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/17342/#comment66872>
CHECK_READY would be nice in these methods, I see it's in review :)
src/log/log.hpp
<https://reviews.apache.org/r/17342/#comment66870>
This comment needs updating to remove 'none'.
src/log/log.hpp
<https://reviews.apache.org/r/17342/#comment66871>
This comment needs updating for 'none'.
- Ben Mahler
On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17342/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17342/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17342: Updated Log::Reader and Log::Writer to be
asynchronous.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17342/#review35659
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Feb. 19, 2014, 12:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17342/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 12:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17342/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17342: Updated Log::Reader and Log::Writer to be
asynchronous.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17342/#review36351
-----------------------------------------------------------
Bad patch!
Reviews applied: [17342]
Failed command: git apply --index 17342.patch
Error:
error: patch failed: src/java/jni/org_apache_mesos_Log.cpp:18
error: src/java/jni/org_apache_mesos_Log.cpp: patch does not apply
- Mesos ReviewBot
On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17342/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17342/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17342: Updated Log::Reader and Log::Writer to be
asynchronous.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17342/#review34874
-----------------------------------------------------------
src/tests/log_tests.cpp
<https://reviews.apache.org/r/17342/#comment65257>
i might be missing it, but do any of the tests exercise the error cases (timeout, not ready, etc)?
- Dominic Hamon
On Feb. 19, 2014, 12:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17342/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 12:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17342/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>