You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2013/12/10 02:46:36 UTC
[1/2] git commit: CB-5613 use throw Error to include stack
information for -d
Updated Branches:
refs/heads/master 02d2d641e -> ec88d6af8
CB-5613 use throw Error to include stack information for -d
Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/3b184f4f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/3b184f4f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/3b184f4f
Branch: refs/heads/master
Commit: 3b184f4f010d9877e72ce9aaf216565ee54b772b
Parents: 02d2d64
Author: Josh Soref <js...@blackberry.com>
Authored: Mon Dec 9 15:48:46 2013 -0500
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Dec 9 20:44:10 2013 -0500
----------------------------------------------------------------------
src/config.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/3b184f4f/src/config.js
----------------------------------------------------------------------
diff --git a/src/config.js b/src/config.js
index 4f4916a..5f2836c 100644
--- a/src/config.js
+++ b/src/config.js
@@ -49,7 +49,7 @@ module.exports.read = function get_config(project_root) {
JSHINT(data);
var err = JSHINT.errors[0];
if (err) {
- throw 'Parsing "'+config_json+'" at line '+err.line+" col "+err.character+"; "+err.reason;
+ throw new Error('Parsing "'+config_json+'" at line '+err.line+" col "+err.character+"; "+err.reason);
}
throw e;
}
[2/2] git commit: CB-5613 Never hide stack trace on
uncaughtExceptions.
Posted by ag...@apache.org.
CB-5613 Never hide stack trace on uncaughtExceptions.
Uncaught exceptions are bugs, so stack traces are always helpful.
Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/ec88d6af
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/ec88d6af
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/ec88d6af
Branch: refs/heads/master
Commit: ec88d6af82a73964abc96e258d4d698c4f2825b9
Parents: 3b184f4
Author: Andrew Grieve <ag...@chromium.org>
Authored: Mon Dec 9 20:45:46 2013 -0500
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Dec 9 20:45:46 2013 -0500
----------------------------------------------------------------------
src/cli.js | 9 ---------
1 file changed, 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/ec88d6af/src/cli.js
----------------------------------------------------------------------
diff --git a/src/cli.js b/src/cli.js
index ef3ba58..2916062 100755
--- a/src/cli.js
+++ b/src/cli.js
@@ -48,15 +48,6 @@ module.exports = function CLI(inputArgs) {
},
cmd;
- // provide clean output on exceptions rather than dumping a stack trace
- process.on('uncaughtException', function(err){
- if (opts.verbose) {
- console.error(err.stack);
- } else {
- console.error(err);
- }
- process.exit(1);
- });
cordova.on('results', console.log);
if (!opts.silent) {