You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/22 07:15:15 UTC
[GitHub] [zookeeper] kana112233 opened a new pull request #1327: Extra horizontal lines
kana112233 opened a new pull request #1327:
URL: https://github.com/apache/zookeeper/pull/1327
I packaged zookeeper 3.4.14 by reading README_packaging.txt.
I found the two command have extra horizontal lines.
···
apt-get --install cppunit
apt-get --install python-setuptools
···
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] TisonKun commented on issue #1327: Extra horizontal lines
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1327:
URL: https://github.com/apache/zookeeper/pull/1327#issuecomment-617602595
> > LGTM.
> > Does this issue occur also on master or 3.5.x/3.6.x?
>
> yes
If our committers give their approval I think it would be nice to also port the fix to those branches then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kana112233 commented on issue #1327: Extra horizontal lines
Posted by GitBox <gi...@apache.org>.
kana112233 commented on issue #1327:
URL: https://github.com/apache/zookeeper/pull/1327#issuecomment-617609455
> > > LGTM.
> > > Does this issue occur also on master or 3.5.x/3.6.x?
> >
> >
> > yes
>
> If our committers give their approval I think it would be nice to also port the fix to those branches then.
3.6.x and master are OK.
3.4.x and 3.5.x are wrong.
3.5.x pr: #1328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kana112233 commented on issue #1327: Extra horizontal lines
Posted by GitBox <gi...@apache.org>.
kana112233 commented on issue #1327:
URL: https://github.com/apache/zookeeper/pull/1327#issuecomment-617601582
> LGTM.
>
> Does this issue occur also on master or 3.5.x/3.6.x?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kana112233 commented on issue #1327: Extra horizontal lines
Posted by GitBox <gi...@apache.org>.
kana112233 commented on issue #1327:
URL: https://github.com/apache/zookeeper/pull/1327#issuecomment-618248737
> actually... you used wrong target branch in your PR (branch-3.4 should be used, as 3.4.14 was already released)
> also, I am not sure if we will need this on branch 3.4, as we won't have any more 3.4 release, 3.4 is EOL now: https://mail-archives.apache.org/mod_mbox/zookeeper-user/202004.mbox/browser
>
> but of course on 3.5 it makes sense
See PR #1329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kana112233 edited a comment on issue #1327: Extra horizontal lines
Posted by GitBox <gi...@apache.org>.
kana112233 edited a comment on issue #1327:
URL: https://github.com/apache/zookeeper/pull/1327#issuecomment-618248737
> actually... you used wrong target branch in your PR (branch-3.4 should be used, as 3.4.14 was already released)
> also, I am not sure if we will need this on branch 3.4, as we won't have any more 3.4 release, 3.4 is EOL now: https://mail-archives.apache.org/mod_mbox/zookeeper-user/202004.mbox/browser
>
> but of course on 3.5 it makes sense
Re-submit PR #1329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org