You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org> on 2006/07/08 20:18:30 UTC

[jira] Commented: (TAPESTRY-802) All Tapestry URLs should be encoded using RequestCycle.encodeURL(), except for portlets URLs

    [ http://issues.apache.org/jira/browse/TAPESTRY-802?page=comments#action_12419871 ] 

Jesse Kuhnert commented on TAPESTRY-802:
----------------------------------------

Sorry it took so long Andy, but I do finally understand your problem with the way this is done. The LinkFactory already handles encoding of session information when necessary, so using IRequestCycle.encodeURL() is absolutely not an acceptable way to do the encoding of URL's returned from link factory. 

If this is a portlet only construct then perhaps things need to be re-factored for the portlet services. I'm leaving this issue open but am about to remove encodeURL() from the normal semantics for now. (Finally ran the workbench). 

I'll try and come up with an answer for this for portlets before 4.1 is officially released. 

> All Tapestry URLs should be encoded using RequestCycle.encodeURL(), except for portlets URLs
> --------------------------------------------------------------------------------------------
>
>          Key: TAPESTRY-802
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-802
>      Project: Tapestry
>         Type: Bug

>   Components: Framework, Portlet
>     Versions: 4.0
>  Environment: WSRP4J
> Tapestry 4.0rc1
>     Reporter: Raphael Jean
>     Priority: Minor
>      Fix For: 4.1
>  Attachments: TAPESTRY-802-patch.txt
>
> All Tapestry URLs referencing the Tapestry servlet or context assets should be encoded using RequestCycle.encodeURL() whether the link is stateless or not.
> In portlet mode, the portlet URLs obtained by createActionURL() or createRenderURL() should NOT be encoded.
> Failure to do so causes problems when running as a WSRP producer where the URLs will be WSRP defined tokens that get re-written by the WSRP container. Action, render and resource URLs are encoded differently.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org