[hbase] branch branch-2.5 updated: HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.lang.ClassCastException (#5346) (#5425)

[ni...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

nihaljain pushed a commit to branch branch-2.5
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.5 by this push:
     new 70d136b6005 HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.lang.ClassCastException (#5346) (#5425)
70d136b6005 is described below

commit 70d136b6005df58f66784bb2a92e238cd12e68e1
Author: Nihal Jain <ni...@apache.org>
AuthorDate: Tue Sep 26 12:32:23 2023 +0530

    HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.lang.ClassCastException (#5346) (#5425)
    
    Co-authored-by: Nikita Pande <ni...@gmail.com>
    Signed-off-by: Nihal Jain <ni...@apache.org>
    Signed-off-by: Nick Dimiduk <nd...@apache.org>
    (cherry picked from commit 8caebc355280c346aeb256338bc95b8cc0350a8f)
---
 .../client/example/MultiThreadedClientExample.java |  6 +-
 .../example/TestMultiThreadedClientExample.java    | 73 ++++++++++++++++++++++
 2 files changed, 77 insertions(+), 2 deletions(-)

diff --git a/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/MultiThreadedClientExample.java b/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/MultiThreadedClientExample.java
index a443f89bbae..7279a2555f2 100644
--- a/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/MultiThreadedClientExample.java
+++ b/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/MultiThreadedClientExample.java
@@ -23,10 +23,11 @@ import java.util.List;
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
-import java.util.concurrent.ForkJoinPool;
 import java.util.concurrent.Future;
+import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
 import org.apache.hadoop.conf.Configured;
 import org.apache.hadoop.hbase.Cell;
@@ -129,7 +130,8 @@ public class MultiThreadedClientExample extends Configured implements Tool {
     //
     // We don't want to mix hbase and business logic.
     //
-    ExecutorService service = new ForkJoinPool(threads * 2);
+    ThreadPoolExecutor service = new ThreadPoolExecutor(threads * 2, threads * 2, 60L,
+      TimeUnit.SECONDS, new LinkedBlockingQueue<>());
 
     // Create two different connections showing how it's possible to
     // separate different types of requests onto different connections
diff --git a/hbase-examples/src/test/java/org/apache/hadoop/hbase/client/example/TestMultiThreadedClientExample.java b/hbase-examples/src/test/java/org/apache/hadoop/hbase/client/example/TestMultiThreadedClientExample.java
new file mode 100644
index 00000000000..0db1b229361
--- /dev/null
+++ b/hbase-examples/src/test/java/org/apache/hadoop/hbase/client/example/TestMultiThreadedClientExample.java
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client.example;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.testclassification.ClientTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category({ ClientTests.class, MediumTests.class })
+public class TestMultiThreadedClientExample {
+
+  private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();
+  private static String tableName = "test_mt_table";
+  private static Table table;
+  static final TableName MY_TABLE_NAME = TableName.valueOf(tableName);
+  private static byte[] familyName = Bytes.toBytes("d");
+  private static byte[] columnName = Bytes.toBytes("col");
+
+  @ClassRule
+  public static final HBaseClassTestRule CLASS_RULE =
+    HBaseClassTestRule.forClass(TestMultiThreadedClientExample.class);
+
+  @BeforeClass
+  public static void setup() throws Exception {
+    TEST_UTIL.startMiniCluster(1);
+    table = TEST_UTIL.createTable(MY_TABLE_NAME, familyName);
+  }
+
+  @AfterClass
+  public static void tearDown() throws Exception {
+    TEST_UTIL.deleteTable(MY_TABLE_NAME);
+    TEST_UTIL.shutdownMiniCluster();
+  }
+
+  @Test
+  public void testMultiThreadedClientExample() throws Exception {
+    MultiThreadedClientExample example = new MultiThreadedClientExample();
+    example.setConf(TEST_UTIL.getConfiguration());
+    String[] args = { tableName, "200" };
+    // Define assertions to check the returned data here
+    assertEquals(0, example.run(args));
+    // Define assertions to check the row count of the table
+    int rows = TEST_UTIL.countRows(table);
+    assertNotEquals(0, rows);
+  }
+}