You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/02 21:31:41 UTC
[GitHub] [geode] bschuchardt opened a new pull request #6079: GEODE-8979: CI Failure: SSLSocketHostNameVerificationIntegrationTest
bschuchardt opened a new pull request #6079:
URL: https://github.com/apache/geode/pull/6079
This test was closing a client socket before ensuring that a thread it
had created was finished. If the socket is closed quickly enough it
could cause that thread to get an IOException and cause the test to
fail.
The fix is to ensure that the thread is finished before closing the
client socket.
@kamilla1201
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] echobravopapa commented on a change in pull request #6079: GEODE-8979: CI Failure: SSLSocketHostNameVerificationIntegrationTest
Posted by GitBox <gi...@apache.org>.
echobravopapa commented on a change in pull request #6079:
URL: https://github.com/apache/geode/pull/6079#discussion_r586663171
##########
File path: geode-core/src/integrationTest/java/org/apache/geode/internal/net/SSLSocketHostNameVerificationIntegrationTest.java
##########
@@ -211,18 +211,17 @@ private Thread startServerNIO(final ServerSocket serverSocket, int timeoutMillis
} catch (Throwable throwable) {
serverException = throwable;
} finally {
- if (engine != null && socket != null) {
+ if (engine != null) {
Review comment:
what a helpful tool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] bschuchardt merged pull request #6079: GEODE-8979: CI Failure: SSLSocketHostNameVerificationIntegrationTest
Posted by GitBox <gi...@apache.org>.
bschuchardt merged pull request #6079:
URL: https://github.com/apache/geode/pull/6079
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] echobravopapa commented on a change in pull request #6079: GEODE-8979: CI Failure: SSLSocketHostNameVerificationIntegrationTest
Posted by GitBox <gi...@apache.org>.
echobravopapa commented on a change in pull request #6079:
URL: https://github.com/apache/geode/pull/6079#discussion_r586011011
##########
File path: geode-core/src/integrationTest/java/org/apache/geode/internal/net/SSLSocketHostNameVerificationIntegrationTest.java
##########
@@ -211,18 +211,17 @@ private Thread startServerNIO(final ServerSocket serverSocket, int timeoutMillis
} catch (Throwable throwable) {
serverException = throwable;
} finally {
- if (engine != null && socket != null) {
+ if (engine != null) {
Review comment:
null check is no longer needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] bschuchardt commented on a change in pull request #6079: GEODE-8979: CI Failure: SSLSocketHostNameVerificationIntegrationTest
Posted by GitBox <gi...@apache.org>.
bschuchardt commented on a change in pull request #6079:
URL: https://github.com/apache/geode/pull/6079#discussion_r586573032
##########
File path: geode-core/src/integrationTest/java/org/apache/geode/internal/net/SSLSocketHostNameVerificationIntegrationTest.java
##########
@@ -211,18 +211,17 @@ private Thread startServerNIO(final ServerSocket serverSocket, int timeoutMillis
} catch (Throwable throwable) {
serverException = throwable;
} finally {
- if (engine != null && socket != null) {
+ if (engine != null) {
Review comment:
Intellij informed me that if (engine != null) it isn't possible that (socket == null). I agreed & removed that check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org