[GitHub] npawar commented on issue #3644: Split ValidationManager duties into separate ControllerPeriodicTasks

[GitBox <gi...@apache.org>]

npawar commented on issue #3644: Split ValidationManager duties into separate ControllerPeriodicTasks
URL: https://github.com/apache/incubator-pinot/pull/3644#issuecomment-451616378
 
 
   Thanks for pointing that out @mcvsubbu 
   I went over the reads that happen in all 3 tasks.
   
   1. OfflineSegmentIntervalChecker
    reads ideal state of offline table
   reads all segment metadata for the offline table
   
   2. RealtimeSegmentValidationManager
   reads ideal state of realtime table
   reads only names of all segment metadata for the realtime table
   reads all instance configs inside StreamPartitionAssignmentGenerator for the table
   
   3. BrokerResourceValidationManager
   reads ideal state for the table
   reads instance configs once in preprocess
   
   It doesn't look like any reads will be repeated _because_ of splitting out these tasks. 1 and 2 read different ideal state/segment metadata. 2 and 3 both read instance configs, which they both did even before splitting, so it's not a new addition. The instance configs read will be better anyway after https://github.com/apache/incubator-pinot/pull/3633
   
   Let me know what you think
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org