You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/04 15:09:41 UTC
[GitHub] [pulsar] sijie commented on a change in pull request #5557:
[Broker]Fix api healthcheck
sijie commented on a change in pull request #5557: [Broker]Fix api healthcheck
URL: https://github.com/apache/pulsar/pull/5557#discussion_r342097998
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
##########
@@ -269,9 +270,9 @@ public void healthcheck(@Suspended AsyncResponse asyncResponse) throws Exception
asyncResponse.resume(new RestException(e));
return;
}
- CompletableFuture<Producer<String>> producerFuture =
- client.newProducer(Schema.STRING).topic(topic).createAsync();
- CompletableFuture<Reader<String>> readerFuture = client.newReader(Schema.STRING)
+ CompletableFuture<Producer<byte[]>> producerFuture =
Review comment:
nit: If you are using `SchemaDisabled`, you don't need switch to `byte[]` schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services