You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/23 04:09:00 UTC
[GitHub] [incubator-kyuubi] lightning-L opened a new pull request, #3680: [KYUUBI #3679] Admin command line supports delete/list engine operation
lightning-L opened a new pull request, #3680:
URL: https://github.com/apache/incubator-kyuubi/pull/3680
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3680: [KYUUBI #3679] Admin command line supports delete/list engine operation
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3680:
URL: https://github.com/apache/incubator-kyuubi/pull/3680#issuecomment-1288366257
thanks @lightning-L, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #3680: [KYUUBI #3679] Admin command line supports delete/list engine operation
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3680: [KYUUBI #3679] Admin command line supports delete/list engine operation
URL: https://github.com/apache/incubator-kyuubi/pull/3680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3680: [KYUUBI #3679] Admin command line supports delete/list engine operation
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3680:
URL: https://github.com/apache/incubator-kyuubi/pull/3680#issuecomment-1287999246
@turboFei
added delete/list engine operation for kyuubi-admin ctl
reorganized and refactored some kyuubi-ctl classes
moved hs2ProxyUser from batchOpts to commonOpts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3680: [KYUUBI #3679] Admin command line supports delete/list engine operation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3680:
URL: https://github.com/apache/incubator-kyuubi/pull/3680#issuecomment-1288006959
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3680](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb3a133) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b2210d928c953d87c5fbc9faee78d7c69c8d0d26?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2210d9) will **increase** coverage by `0.09%`.
> The diff coverage is `89.93%`.
```diff
@@ Coverage Diff @@
## master #3680 +/- ##
============================================
+ Coverage 52.11% 52.20% +0.09%
Complexity 13 13
============================================
Files 485 489 +4
Lines 27274 27362 +88
Branches 3804 3809 +5
============================================
+ Hits 14213 14285 +72
- Misses 11687 11699 +12
- Partials 1374 1378 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/kyuubi/ctl/RestClientFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvUmVzdENsaWVudEZhY3Rvcnkuc2NhbGE=) | `93.33% <ø> (ø)` | |
| [...la/org/apache/kyuubi/ctl/cli/AdminControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY2xpL0FkbWluQ29udHJvbENsaS5zY2FsYQ==) | `35.00% <ø> (ø)` | |
| [...n/scala/org/apache/kyuubi/ctl/cli/ControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY2xpL0NvbnRyb2xDbGkuc2NhbGE=) | `46.42% <ø> (ø)` | |
| [...rg/apache/kyuubi/ctl/cli/ControlCliArguments.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY2xpL0NvbnRyb2xDbGlBcmd1bWVudHMuc2NhbGE=) | `32.50% <0.00%> (ø)` | |
| [...che/kyuubi/ctl/cli/ControlCliArgumentsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY2xpL0NvbnRyb2xDbGlBcmd1bWVudHNQYXJzZXIuc2NhbGE=) | `100.00% <ø> (ø)` | |
| [...la/org/apache/kyuubi/ctl/cmd/AdminCtlCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL0FkbWluQ3RsQ29tbWFuZC5zY2FsYQ==) | `50.00% <ø> (ø)` | |
| [...main/scala/org/apache/kyuubi/ctl/cmd/Command.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL0NvbW1hbmQuc2NhbGE=) | `83.33% <ø> (ø)` | |
| [...che/kyuubi/ctl/cmd/create/CreateBatchCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2NyZWF0ZS9DcmVhdGVCYXRjaENvbW1hbmQuc2NhbGE=) | `95.83% <ø> (ø)` | |
| [...he/kyuubi/ctl/cmd/create/CreateServerCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2NyZWF0ZS9DcmVhdGVTZXJ2ZXJDb21tYW5kLnNjYWxh) | `86.48% <ø> (ø)` | |
| [...g/apache/kyuubi/ctl/cmd/delete/DeleteCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2RlbGV0ZS9EZWxldGVDb21tYW5kLnNjYWxh) | `100.00% <ø> (ø)` | |
| ... and [33 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3680/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org