You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/26 23:34:42 UTC
Review Request 26102: Dropping assert on empty desired instances set.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-756
https://issues.apache.org/jira/browse/AURORA-756
Repository: aurora
Description
-------
Dropping assert on empty desired instances set.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
Diff: https://reviews.apache.org/r/26102/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 26, 2014, 11:35 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line 724
> > <https://reviews.apache.org/r/26102/diff/1/?file=706432#file706432line724>
> >
> > IIUC you could also trip this with an update that reduces the instance count in a job. Can you add a test case for that?
Thanks for bringing this up! I now remember exactly why I did not want to address it in my previous changelist as it required changes in SchedulerThriftInterface to avoid setting TaskConfig if Range set is empty. Otherwise, the sql layer assert will fire.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54751
-----------------------------------------------------------
On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 9:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54751
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
<https://reviews.apache.org/r/26102/#comment95041>
IIUC you could also trip this with an update that reduces the instance count in a job. Can you add a test case for that?
- Bill Farner
On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 9:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java, line 88
> > <https://reviews.apache.org/r/26102/diff/2/?file=708338#file708338line88>
> >
> > Your call on whether this makes things more readable, but i could imagine some cleanup here:
> >
> > Function<.., ..> toResources;
> >
> > IResourceAggregate desired = desiredState.transform(TO_RESOURCES).or(EMPTY);
Sure, why not.
> On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1357
> > <https://reviews.apache.org/r/26102/diff/2/?file=708339#file708339line1357>
> >
> > @Nullable, though i wouldn't mind seeing Optional here and orNull() below.
Done.
> On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line 736
> > <https://reviews.apache.org/r/26102/diff/2/?file=708343#file708343line736>
> >
> > Would still like to see the test case for update behavior when instanceCount is reduced, and TaskConfig is unchanged.
Thanks, added and fixed a few more issues.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54861
-----------------------------------------------------------
On Sept. 29, 2014, 8:04 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 8:04 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54861
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java
<https://reviews.apache.org/r/26102/#comment95176>
Your call on whether this makes things more readable, but i could imagine some cleanup here:
Function<.., ..> toResources;
IResourceAggregate desired = desiredState.transform(TO_RESOURCES).or(EMPTY);
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/26102/#comment95177>
@Nullable, though i wouldn't mind seeing Optional here and orNull() below.
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
<https://reviews.apache.org/r/26102/#comment95178>
Would still like to see the test case for update behavior when instanceCount is reduced, and TaskConfig is unchanged.
- Bill Farner
On Sept. 29, 2014, 8:04 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 8:04 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java, line 197
> > <https://reviews.apache.org/r/26102/diff/3/?file=708816#file708816line197>
> >
> > Adding optional here seems circuitous. Why not avoid calling `asMap` if `config` is null?
> >
> > instructions.isSetDesiredState() ? asMap(..) : ImmutableMap.of()
> >
> > This matches the approach you used in `UpdateFactory`.
I guess if it does not have to be public I agree. Changed it to private and dropped Optional<>.
> On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java, line 57
> > <https://reviews.apache.org/r/26102/diff/3/?file=708815#file708815line57>
> >
> > Comment lacks context. This should suffice:
> >
> > // Desired state is assumed to be non-null when AddTask is used.
Done.
> On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java, line 377
> > <https://reviews.apache.org/r/26102/diff/3/?file=708818#file708818line377>
> >
> > s/DoesNotThrow//
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54911
-----------------------------------------------------------
On Sept. 29, 2014, 10:57 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 10:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664
> src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54911
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java
<https://reviews.apache.org/r/26102/#comment95243>
Comment lacks context. This should suffice:
// Desired state is assumed to be non-null when AddTask is used.
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java
<https://reviews.apache.org/r/26102/#comment95244>
Adding optional here seems circuitous. Why not avoid calling `asMap` if `config` is null?
instructions.isSetDesiredState() ? asMap(..) : ImmutableMap.of()
This matches the approach you used in `UpdateFactory`.
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java
<https://reviews.apache.org/r/26102/#comment95245>
s/DoesNotThrow//
- Bill Farner
On Sept. 29, 2014, 10:57 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 10:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664
> src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54919
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java
<https://reviews.apache.org/r/26102/#comment95255>
rejigger this so the ImmutableMap.copyOf doesn't wrap the ImmutableMap.of
- Bill Farner
On Sept. 29, 2014, 11:32 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 11:32 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-756
> https://issues.apache.org/jira/browse/AURORA-756
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping assert on empty desired instances set.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664
> src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 62d08ad141f271ffb2627df138a5ef445f8f88d7
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4934cbbc55e14756c7719be1bd7bb8dc1f31592f
>
> Diff: https://reviews.apache.org/r/26102/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
-----------------------------------------------------------
(Updated Sept. 29, 2014, 11:32 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-756
https://issues.apache.org/jira/browse/AURORA-756
Repository: aurora
Description
-------
Dropping assert on empty desired instances set.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664
src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427
src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 62d08ad141f271ffb2627df138a5ef445f8f88d7
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4934cbbc55e14756c7719be1bd7bb8dc1f31592f
Diff: https://reviews.apache.org/r/26102/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
-----------------------------------------------------------
(Updated Sept. 29, 2014, 10:57 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-756
https://issues.apache.org/jira/browse/AURORA-756
Repository: aurora
Description
-------
Dropping assert on empty desired instances set.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664
src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427
src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
Diff: https://reviews.apache.org/r/26102/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26102: Dropping assert on empty desired instances
set.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
-----------------------------------------------------------
(Updated Sept. 29, 2014, 8:04 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Updated thrift layer to correctly populate IJobUpdate in case of empty desired state.
Bugs: AURORA-756
https://issues.apache.org/jira/browse/AURORA-756
Repository: aurora
Description
-------
Dropping assert on empty desired instances set.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924
src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314
Diff: https://reviews.apache.org/r/26102/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko