You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2020/09/03 09:37:08 UTC

[GitHub] [bigtop] JunHe77 opened a new pull request #664: BIGTOP-3391: Support GPDB on Perl 5.30+ environment

JunHe77 opened a new pull request #664:
URL: https://github.com/apache/bigtop/pull/664


   GPDB is using a special variable $[ in its Perl script,
   but it was deprecated from v5.30. So it can't be built
   on some distros, e.g., Fedora 31 and Ubuntu 20.04.
   
   This patch fixes indexs used in array and substr functions.
   
   Change-Id: I92c793243c37ce57ffe146b71a5f732488f5e4a9
   Signed-off-by: Jun He <ju...@arm.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #664: BIGTOP-3391: Support GPDB on Perl 5.30+ environment

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #664:
URL: https://github.com/apache/bigtop/pull/664#issuecomment-686381670


   Great work @JunHe77, I searched "[" and "substr" in parse.pl, and this PR seems to contain all required fixes.
   Will try to build gpdb with it on some distros.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #664: BIGTOP-3391: Support GPDB on Perl 5.30+ environment

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #664:
URL: https://github.com/apache/bigtop/pull/664#issuecomment-686428307


   +1, Confirmed building GPDB succeeded on CentOS 7, Debian 9 and Fedora 31. Thanks @JunHe77!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] JunHe77 commented on pull request #664: BIGTOP-3391: Support GPDB on Perl 5.30+ environment

Posted by GitBox <gi...@apache.org>.
JunHe77 commented on pull request #664:
URL: https://github.com/apache/bigtop/pull/664#issuecomment-686395905


   Thanks for helping verifying this, @sekikn 
   I just did quick test by issuing:
   `"/usr/bin/perl" ./parse.pl . < ../../../../src/backend/parser/gram.y > preproc.y`
   in <gpdb_root>/src/interfaces/ecpg/preproc/, with and without this fix to verify the generated prepro.y. So far it looks good as the outputs match.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] JunHe77 commented on pull request #664: BIGTOP-3391: Support GPDB on Perl 5.30+ environment

Posted by GitBox <gi...@apache.org>.
JunHe77 commented on pull request #664:
URL: https://github.com/apache/bigtop/pull/664#issuecomment-686376969


   This also fixes greenplum-db/gpdb#8989


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn merged pull request #664: BIGTOP-3391: Support GPDB on Perl 5.30+ environment

Posted by GitBox <gi...@apache.org>.
sekikn merged pull request #664:
URL: https://github.com/apache/bigtop/pull/664


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org