You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/08/06 18:39:05 UTC
[GitHub] [airflow] eumiro opened a new pull request, #33159: Refactor: Simplify dict manipulation in airflow/cli
eumiro opened a new pull request, #33159:
URL: https://github.com/apache/airflow/pull/33159
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #33159: Refactor: Simplify dict manipulation in airflow/cli
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #33159:
URL: https://github.com/apache/airflow/pull/33159#discussion_r1285404252
##########
airflow/cli/commands/provider_command.py:
##########
@@ -134,7 +134,7 @@ def connection_form_widget_list(args):
def connection_field_behaviours(args):
"""Lists field behaviours."""
AirflowConsole().print_as(
- data=list(ProvidersManager().field_behaviours.keys()),
+ data=list(ProvidersManager().field_behaviours),
Review Comment:
There’s really no particular reason `data` needs to be a sequence; it can just be a `Collection` and avoid the `list` cast. This should be a follow-up PR instead though.
##########
airflow/cli/commands/provider_command.py:
##########
@@ -134,7 +134,7 @@ def connection_form_widget_list(args):
def connection_field_behaviours(args):
"""Lists field behaviours."""
AirflowConsole().print_as(
- data=list(ProvidersManager().field_behaviours.keys()),
+ data=list(ProvidersManager().field_behaviours),
Review Comment:
There’s really no particular reason `data` needs to be a sequence; it can just be a `Collection` and avoid the `list` cast. This should be a follow-up PR instead though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33159: Refactor: Simplify dict manipulation in airflow/cli
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33159:
URL: https://github.com/apache/airflow/pull/33159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org