You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Amin Borjian <bo...@outlook.com> on 2023/04/05 12:57:07 UTC

RE: Re: Discuss on the next Zeppelin release

After below change, we are not going to release a new version to support spark 3.3?

https://github.com/apache/zeppelin/commit/aeb40a5907b42da7d64f22ff1ceb288cc86fa922

https://lists.apache.org/thread/n4mdfwr5ksgpmrz0jpqp335qpvormos1

On 2023/02/24 18:05:20 Philipp Dallig wrote:
> (+1)
>
> I would have converted all tests to JUnit5 before the release if
> possible. This should simplify backports to 0.11.x. If we want to do
> without patch releases in the future, then I am also in favour of a release.
>
> Am 15.02.23 um 08:18 schrieb Jeff Zhang:
> > Hi folks,
> >
> > The last release of Zeppelin (0.10.1) was around one year ago (Feb 2022).
> > Since then, we have made significant improvements on Zeppelin. Do you think
> > it is a good time to make a new release?
> >
> >
> >
>
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows


Re: Discuss on the next Zeppelin release

Posted by Philipp Dallig <ph...@gmail.com>.
Hi JL,

junit5 is definitely not a critical blocker.

My question at this point is, should patch releases (e.g. 0.11.1, 
0.11.2) continue to be generated? Then we would have to backport bugs 
from the master branch to the release branch.
This can be very complicated if the migration to JUnit5 as the central 
test library has not yet been completed.

Current status of the migration:
  - Umbrella JIRA ticket: 
https://issues.apache.org/jira/browse/ZEPPELIN-5848
  - We identified PowerMock as a big blocker in the migration and were 
able to completely remove Powermock with PR 
https://github.com/apache/zeppelin/pull/4580
  - The Zeppelin plugins have been completely migrated to JUnit5
  - Guanhua Li is working on a big change in zeppelin-zengine, see PR 
https://github.com/apache/zeppelin/pull/4532
  - Some interpreters have also already been migrated

What still needs to be done?
  - Migrating the zeppelin-interpreter and zeppelin-server modules can 
be challenging.
  - Migration of most interpreters is certainly easy to do. My guess is 
that only the Spark or Flink interpreter could become more complicated.

If you have any further questions, please feel free to ask :-D

Best Regards
Philipp

Am 12.04.23 um 19:13 schrieb Jongyoul Lee:
> Hello,
>
> I agree with releasing a new version with Junit 5 for the future but I 
> don't think Junit5 is a critical blocker for the release at the same time.
>
> @Philipp Dallig <ma...@gmail.com>
> I don't want to be in a hurry and I'm sorry that I didn't figure out 
> the issue well but could you please give us more information including 
> what's left and so on?
>
> JL
>
> 2023년 4월 5일 (수) 오후 9:57, Amin Borjian 
> <bo...@outlook.com>님이 작성:
>
>     After below change, we are not going to release a new version to
>     support spark 3.3?
>
>     https://github.com/apache/zeppelin/commit/aeb40a5907b42da7d64f22ff1ceb288cc86fa922
>
>     https://lists.apache.org/thread/n4mdfwr5ksgpmrz0jpqp335qpvormos1
>
>     On 2023/02/24 18:05:20 Philipp Dallig wrote:
>     > (+1)
>     >
>     > I would have converted all tests to JUnit5 before the release if
>     > possible. This should simplify backports to 0.11.x. If we want to do
>     > without patch releases in the future, then I am also in favour
>     of a release.
>     >
>     > Am 15.02.23 um 08:18 schrieb Jeff Zhang:
>     > > Hi folks,
>     > >
>     > > The last release of Zeppelin (0.10.1) was around one year ago
>     (Feb 2022).
>     > > Since then, we have made significant improvements on Zeppelin.
>     Do you think
>     > > it is a good time to make a new release?
>     > >
>     > >
>     > >
>     >
>     Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for
>     Windows
>
>
>
> -- 
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net

Re: Discuss on the next Zeppelin release

Posted by Philipp Dallig <ph...@gmail.com>.
Hi JL,

The work on the JUnit5 migration is done in the largest modules. We 
should, in my opinion, do a release now before making any more major 
changes.

Best Regards
Philipp

Am 12.04.23 um 19:13 schrieb Jongyoul Lee:
> Hello,
>
> I agree with releasing a new version with Junit 5 for the future but I 
> don't think Junit5 is a critical blocker for the release at the same time.
>
> @Philipp Dallig <ma...@gmail.com>
> I don't want to be in a hurry and I'm sorry that I didn't figure out 
> the issue well but could you please give us more information including 
> what's left and so on?
>
> JL
>
> 2023년 4월 5일 (수) 오후 9:57, Amin Borjian 
> <bo...@outlook.com>님이 작성:
>
>     After below change, we are not going to release a new version to
>     support spark 3.3?
>
>     https://github.com/apache/zeppelin/commit/aeb40a5907b42da7d64f22ff1ceb288cc86fa922
>
>     https://lists.apache.org/thread/n4mdfwr5ksgpmrz0jpqp335qpvormos1
>
>     On 2023/02/24 18:05:20 Philipp Dallig wrote:
>     > (+1)
>     >
>     > I would have converted all tests to JUnit5 before the release if
>     > possible. This should simplify backports to 0.11.x. If we want to do
>     > without patch releases in the future, then I am also in favour
>     of a release.
>     >
>     > Am 15.02.23 um 08:18 schrieb Jeff Zhang:
>     > > Hi folks,
>     > >
>     > > The last release of Zeppelin (0.10.1) was around one year ago
>     (Feb 2022).
>     > > Since then, we have made significant improvements on Zeppelin.
>     Do you think
>     > > it is a good time to make a new release?
>     > >
>     > >
>     > >
>     >
>     Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for
>     Windows
>
>
>
> -- 
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net

Re: Re: Discuss on the next Zeppelin release

Posted by Jongyoul Lee <jo...@gmail.com>.
Hello,

I agree with releasing a new version with Junit 5 for the future but I
don't think Junit5 is a critical blocker for the release at the same time.

@Philipp Dallig <ph...@gmail.com>
I don't want to be in a hurry and I'm sorry that I didn't figure out
the issue well but could you please give us more information including
what's left and so on?

JL

2023년 4월 5일 (수) 오후 9:57, Amin Borjian <bo...@outlook.com>님이 작성:

> After below change, we are not going to release a new version to support
> spark 3.3?
>
>
> https://github.com/apache/zeppelin/commit/aeb40a5907b42da7d64f22ff1ceb288cc86fa922
>
> https://lists.apache.org/thread/n4mdfwr5ksgpmrz0jpqp335qpvormos1
>
> On 2023/02/24 18:05:20 Philipp Dallig wrote:
> > (+1)
> >
> > I would have converted all tests to JUnit5 before the release if
> > possible. This should simplify backports to 0.11.x. If we want to do
> > without patch releases in the future, then I am also in favour of a
> release.
> >
> > Am 15.02.23 um 08:18 schrieb Jeff Zhang:
> > > Hi folks,
> > >
> > > The last release of Zeppelin (0.10.1) was around one year ago (Feb
> 2022).
> > > Since then, we have made significant improvements on Zeppelin. Do you
> think
> > > it is a good time to make a new release?
> > >
> > >
> > >
> >
> Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
>
>

-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net