[GitHub] rabbah commented on a change in pull request #3902: Add implicit parameters when getting the namespace identity

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3902: Add implicit parameters when getting the namespace identity 
URL: https://github.com/apache/incubator-openwhisk/pull/3902#discussion_r211290249
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala
 ##########
 @@ -460,8 +460,8 @@ trait WhiskWebActionsApi extends Directives with ValidateRequestSize with PostAc
    * This method is factored out to allow mock testing.
    */
   protected def getIdentity(namespace: EntityName)(implicit transid: TransactionId): Future[Identity] = {
-
-    authenticationProvider.identityByNamespace(namespace)(transid, authStore)
+    // ask auth provider to create an identity for the given namespace
+    authenticationProvider.identityByNamespace(namespace)(transid, actorSystem, authStore)
 
 Review comment:
   I think it would have made more sense to put the actorSystem in the Trait; it doesn't seem used in core/controller/src/main/scala/whisk/core/controller/BasicAuthenticationDirective.scala and might be specific to the SPI... is that right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services