You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/11 20:54:41 UTC
[GitHub] [beam] ihji opened a new pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
ihji opened a new pull request #11995:
URL: https://github.com/apache/beam/pull/11995
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642923214
R: @tvalentyn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642932937
@tvalentyn Sure. But we need to block rsa>4.0 in the meantime since it already breaks Python SDK install internal tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642930599
@tvalentyn : 4.2 also doesn't support Python 2. It will throw the exception when apache_beam is imported in Python 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642940930
@tvalentyn Okay. Let's wait and see. If they respond quickly then we don't have to modify our list of dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-643472344
Looks like the author of the library released the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642929884
cc: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642931205
Sigh. They should have added python_requires stanza when they dropped Py2 support in Python RSA. It's a third package that breaks us this way.
I'll open a bug against them and see if they are open to fix this cleanly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642937353
Filed https://github.com/sybrenstuvel/python-rsa/issues/152.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-643459669
let's merge this to unblock others while the new RSA fix comes out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji closed pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji closed pull request #11995:
URL: https://github.com/apache/beam/pull/11995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642965342
@sybrenstuvel Thanks. SGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sybrenstuvel commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
sybrenstuvel commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642948404
Is a fix tomorrow soon enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642937710
Beam does not need to depend directly on `rsa`. To unblock testing, we could temporarily add this dep to testing deps... Or wait for a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642929756
Is there still a problem as of rsa==4.2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11995: [BEAM-10245] block rsa>4.0 for python2 SDK
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-642931107
For context: 'Version 4.0 was the last version to support Python 2"
https://pypi.org/project/rsa/4.2/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org