You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jstastny-cz (via GitHub)" <gi...@apache.org> on 2025/04/29 08:04:39 UTC
[PR] NO-ISSUE: add HEALTHCHECK commands [incubator-kie-tools]
jstastny-cz opened a new pull request, #3087:
URL: https://github.com/apache/incubator-kie-tools/pull/3087
Adding HEALTHCHECK instructions to a few images that I am familiar with.
The HEALTCHECK command is executed as if `docker exec`, so from inside of the container using localhost.
* In case there is an existing ENV with port value, checking that port.
* In case there is an ARG with port value, adding an ENV with the same value so that it can be referenced during runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: add HEALTHCHECK commands [incubator-kie-tools]
Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on PR #3087:
URL: https://github.com/apache/incubator-kie-tools/pull/3087#issuecomment-2839049305
Failing check failed twice in row with:
```
packages/online-editor build:dev: FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: add HEALTHCHECK commands [incubator-kie-tools]
Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on PR #3087:
URL: https://github.com/apache/incubator-kie-tools/pull/3087#issuecomment-2841500672
@thiagoelg seems the NODE_OPTIONS config is not present in the build mode this PR is built with, it ran as `"PARTIAL → Build upstream"` and checking the worflow file:
```
- name: "FULL → Build"
if: steps.setup_build_mode.outputs.mode == 'full'
shell: bash
env:
WEBPACK__minimize: "false"
WEBPACK__tsLoaderTranspileOnly: "false"
KIE_TOOLS_BUILD__runLinters: "true"
KIE_TOOLS_BUILD__runTests: "true"
KIE_TOOLS_BUILD__runEndToEndTests: ${{ runner.os == 'Linux' }}
KIE_TOOLS_BUILD__containerizedEndToEndTests: ${{ runner.os == 'Linux' }}
KIE_TOOLS_BUILD__buildContainerImages: ${{ runner.os == 'Linux' }}
KIE_TOOLS_BUILD__buildExamples: "true"
KIE_TOOLS_BUILD__ignoreTestFailures: ${{ !github.event.pull_request }}
KIE_TOOLS_BUILD__ignoreEndToEndTestFailures: ${{ !github.event.pull_request }}
DISPLAY: ":99.0"
START_SERVER_AND_TEST_INSECURE: "true"
NODE_OPTIONS: "--max_old_space_size=6144"
MAVEN_ARGS: "-B -Puse-maven-repo-local-tail"
MAVEN_OPTS: "-Xmx2g"
run: >-
eval "pnpm ${{ steps.setup_build_mode.outputs.fullBuildPnpmFilterString }} --workspace-concurrency=1 build:prod"
- name: "PARTIAL → Build upstream"
if: steps.setup_build_mode.outputs.mode == 'partial' && steps.setup_build_mode.outputs.upstreamPnpmFilterString != ''
shell: bash
env:
KIE_TOOLS_BUILD__buildContainerImages: ${{ runner.os == 'Linux' }}
KIE_TOOLS_BUILD__buildExamples: "true"
MAVEN_ARGS: "-B -Puse-maven-repo-local-tail"
MAVEN_OPTS: "-Xmx2g"
run: |
eval "pnpm ${{ steps.setup_build_mode.outputs.upstreamPnpmFilterString }} build:dev"
- name: "PARTIAL → Build changed and downstream"
shell: bash
if: steps.setup_build_mode.outputs.mode == 'partial'
env:
WEBPACK__minimize: "false"
KIE_TOOLS_BUILD__runLinters: "true"
KIE_TOOLS_BUILD__runTests: "true"
KIE_TOOLS_BUILD__runEndToEndTests: ${{ runner.os == 'Linux' }}
KIE_TOOLS_BUILD__buildContainerImages: ${{ runner.os == 'Linux' }}
KIE_TOOLS_BUILD__buildExamples: "true"
DISPLAY: ":99.0"
START_SERVER_AND_TEST_INSECURE: "true"
NODE_OPTIONS: "--max_old_space_size=6144"
MAVEN_ARGS: "-B -Puse-maven-repo-local-tail"
MAVEN_OPTS: "-Xmx2g"
run: |
eval "pnpm ${{ steps.setup_build_mode.outputs.affectedPnpmFilterString }} --workspace-concurrency=1 build:prod"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: add HEALTHCHECK commands [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #3087:
URL: https://github.com/apache/incubator-kie-tools/pull/3087#issuecomment-2839228906
I triggered the failing build again, let's see what happens.
It's weird that it's running out of memory... maybe we need to increase the memory limit for NodeJS. We already set it to 4096MB in `.github/workflows/ci_build.yml` with: `NODE_OPTIONS: "--max_old_space_size=4096"`.
If the problem persists, we can try to increase this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add HEALTHCHECK commands [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #3087:
URL: https://github.com/apache/incubator-kie-tools/pull/3087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: add HEALTHCHECK commands [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #3087:
URL: https://github.com/apache/incubator-kie-tools/pull/3087#issuecomment-2839442255
https://github.com/apache/incubator-kie-tools/pull/3091 <- Increased to 6GB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org